Skip to content

Effects: add tests for using jQuery.speed directly #2724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
timmywil wants to merge 1 commit into from
Closed

Effects: add tests for using jQuery.speed directly #2724

timmywil wants to merge 1 commit into from

Conversation

@timmywil
Copy link
Member

@timmywil timmywil commented Nov 16, 2015

Fixes gh-2716

@dmethvin
Copy link
Member

dmethvin commented Nov 17, 2015

Looks pretty thorough. Could we add a test for jQuery.fx.off returning duration: 0 as well? Right now the only test we do for it is for an edge case.

@timmywil
Copy link
Member Author

timmywil commented Nov 17, 2015

@dmethvin Actually, that's here

@dmethvin
Copy link
Member

dmethvin commented Nov 17, 2015

dunno how i missed that! LGTM

@timmywil timmywil closed this in cb80b42 Nov 17, 2015
@timmywil timmywil deleted the speed-2716 branch November 17, 2015 20:12
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timmywil @dmethvin @jquerybot