Ajax: Preserve URL hash on requests #2721
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ajax.js
Outdated
Member
There was a problem hiding this comment.
The final value of cacheURL only matters if s.ifModified is true, but I think it should include _ parameters that come from the user rather than us. What if we updated like so?
uncached = s.url.slice( cacheURL.length );
if ( s.data ) {
cacheURL += ( rquery.test( cacheURL ) ? "&" : "?" ) + s.data;
…
}
if ( s.cache === false ) {
cacheURL = cacheURL.replace( rts, "" );
uncached = ( rquery.test( cacheURL ) ? "&" : "?" ) + "_=" + (nonce++) + uncached;
}
s.url = cacheURL + uncached;
Member
|
/cc @jaubourg |
Member
|
@dmethvin When you submit a PR fixing an issue, please add the "Has Pull Request" label to the issue. |
Member
Author
|
@mzgol I can almost guarantee you that I will continue to forget. It seems that any PR containing "Fixes #xxxx" will put a reference in the issue so it can be detected that way. I guess we could have a bot auto-tag it? |
Member
|
@dmethvin That's the problem with automation that's not automated, isn't it? 😄
Sounds like a good idea. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-1732