Effects: Don't expose jQuery.speed #2713
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jQuery.speed is undocumented internal APIs they shouldn't be exposed.
Member
|
cc @gnarf @gibson042 |
Member
|
We should either hide it as you did in this PR (thanks for it, @sculove!) or document it if it's needed externally. |
Member
|
If UI uses it, we should probably document it. |
Member
Agreed. And test. There are currently no tests for |
Member
|
Closing this in favor of documenting. Thank you for bringing this to our attention, @sculove. |
This was referenced Nov 13, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jQuery.speed is undocumented internal APIs
they shouldn't be exposed.