Skip to content

Attributes: fix tabIndex on <img> in IE11 #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Queeniebee wants to merge 1 commit into from
Closed

Attributes: fix tabIndex on <img> in IE11 #2664

Queeniebee wants to merge 1 commit into from

Conversation

@Queeniebee
Copy link
Contributor

@Queeniebee Queeniebee commented Oct 18, 2015

Fixes gh-2647

dmethvin
dmethvin reviewed Oct 18, 2015
View reviewed changes
src/attributes/prop.js
Copy link
Member

@dmethvin dmethvin Oct 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a // Support comment?

Copy link
Member

@mgol mgol Oct 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good remark, I'll add it later.

Copy link
Member

@mgol mgol Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9cb89bf.

Copy link
Member

@markelog markelog Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how long your todo list, if "later" is four months :)

Copy link
Member

@mgol mgol Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too long. :-) I'm working on that!

@mgol mgol closed this in c752a50 Oct 18, 2015
gibson042 pushed a commit that referenced this pull request Oct 25, 2015
@Queeniebee @gibson042
Attributes: fix tabIndex on <img> in IE11
cf4092e 
Fixes gh-2647
Closes gh-2664

(cherry picked from commit c752a50)

Conflicts:
	src/attributes/prop.js
mgol added a commit that referenced this pull request Feb 3, 2016
@mgol
Attributes: Add a support comment & fix a link @ tabIndex hook
9cb89bf 
Ref gh-2664
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Queeniebee @dmethvin @markelog @mgol @jquerybot