Skip to content

Core: make isNumeric limited to strings and numbers #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timmywil merged 1 commit into from
Oct 21, 2015
Merged

Core: make isNumeric limited to strings and numbers #2663

timmywil merged 1 commit into from
Oct 21, 2015

Conversation

@timmywil
Copy link
Member

@timmywil timmywil commented Oct 18, 2015

  • This is a little more bulletproof in regards to future JS type additions.
  • It is only different than what we currently have in one case.
  • While the documentation has good examples, we need to be more explicit about how our isNumeric tries to coerce strings.

Fixes gh-2662

dmethvin
dmethvin reviewed Oct 20, 2015
View reviewed changes
src/core.js Outdated
Copy link
Member

@dmethvin dmethvin Oct 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "now" will be a bit confusing over time, I'd just remove it.

@timmywil timmywil force-pushed the gh-2662 branch 2 times, most recently from a8f3fa8 to 15ac848 Compare October 21, 2015 20:22
@timmywil timmywil merged commit 15ac848 into jquery:master Oct 21, 2015
@timmywil timmywil deleted the gh-2662 branch October 21, 2015 20:22
stevemao
stevemao reviewed Dec 16, 2015
View reviewed changes
src/core.js
Copy link
Contributor

@stevemao stevemao Dec 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep this comment here :)
@timmywil can we bring it back?

Copy link
Member Author

@timmywil timmywil Dec 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that shouldn't have been removed.

@stevemao stevemao mentioned this pull request Dec 17, 2015
Closed
stevemao added a commit to stevemao/jquery that referenced this pull request Jan 14, 2016
@stevemao
Core: improve isNumeric logic
dfeb00f 
Add back accidentally deleted comments about the implementation.
Add tests for new number literals.

Ref jquery#2663
Ref jquery#2781
Ref jquery#2780
@stevemao stevemao mentioned this pull request Jan 14, 2016
Closed
stevemao added a commit to stevemao/jquery that referenced this pull request Jan 24, 2016
@stevemao
Core: improve isNumeric logic
688bfcc 
Add back accidentally deleted comments about the implementation.
Add tests for new number literals.

Ref jquery#2663
Ref jquery#2781
Ref jquery#2780
gibson042 pushed a commit that referenced this pull request Jan 25, 2016
@stevemao @gibson042
Core: Improve isNumeric logic and test coverage
7103d8e 
Also add back accidentally deleted comments about the implementation.

Fixes gh-2780
Ref gh-2663
Ref gh-2781
Closes gh-2827
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@timmywil @dmethvin @stevemao @jquerybot