Skip to content

Core: Use window.setTimeout & friends when provided #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgol wants to merge 1 commit into from
Closed

Core: Use window.setTimeout & friends when provided #2392

mgol wants to merge 1 commit into from

Conversation

@mgol
Copy link
Member

@mgol mgol commented Jun 14, 2015

Fixes gh-2177

More convoluted than #2391 but +51 bytes instead of +60.

This was referenced Jun 14, 2015
Closed
Closed
mgol
mgol reviewed Jun 14, 2015
View reviewed changes
src/intro.js
Copy link
Member Author

@mgol mgol Jun 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is best viewed with ?w=1 in the URL. ;)

@mgol mgol force-pushed the window-settimeout2 branch from 1b038d9 to ad4a38f Compare June 15, 2015 00:27
@mgol
Copy link
Member Author

mgol commented Jun 15, 2015

I guess this won't work in the AMD mode...

This was referenced Jun 15, 2015
Closed
Merged
@mgol
Copy link
Member Author

mgol commented Jun 16, 2015

Closing in favor of #2397.

@mgol mgol closed this Jun 16, 2015
@mgol mgol deleted the window-settimeout2 branch June 16, 2015 18:11
@mgol mgol removed the Needs review label Jun 16, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Core

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgol @jquerybot