Skip to content

Effects: Remove additional parameters of easings #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mr21 wants to merge 2 commits into from
Closed

Effects: Remove additional parameters of easings #2376

mr21 wants to merge 2 commits into from

Conversation

@mr21
Copy link
Contributor

@mr21 mr21 commented Jun 3, 2015

Hi :)

A fix for #2367

gibson042
gibson042 reviewed Jun 3, 2015
View reviewed changes
src/effects/Tween.js Outdated
Copy link
Member

@gibson042 gibson042 Jun 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last percent should have its own line.

Copy link
Contributor Author

@mr21 mr21 Jun 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

@gibson042
Copy link
Member

gibson042 commented Jun 3, 2015

I like it!

@gnarf
Copy link
Member

gnarf commented Jun 10, 2015

Could we try to land #2326 first and then you can update the test I wrote in there as well?

@mr21
Copy link
Contributor Author

mr21 commented Jun 10, 2015

After you ;)

@mr21 mr21 force-pushed the easing-parameters branch from c978759 to 89372e4 Compare June 27, 2015 15:03
@mr21 mr21 force-pushed the easing-parameters branch from 89372e4 to c541984 Compare June 27, 2015 15:18
@mr21
Copy link
Contributor Author

mr21 commented Jun 27, 2015

@gnarf, it's merged :)

gnarf
gnarf reviewed Jun 27, 2015
View reviewed changes
test/unit/tween.js Outdated
Copy link
Member

@gnarf gnarf Jun 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the comment here the "back-compat" arguments you removed :)

Copy link
Contributor Author

@mr21 mr21 Jun 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:
ok( easingSpy.calledWith( 0.1 ), "...using jQuery.easing.linear" );

@gnarf
Copy link
Member

gnarf commented Jun 27, 2015

Can we make an issue on the jQuery migrate plugin to add a shim to put the additional easing params back?

@gnarf gnarf mentioned this pull request Jun 27, 2015
Closed
@gnarf gnarf mentioned this pull request Jun 27, 2015
Open
@mgol
Copy link
Member

mgol commented Aug 17, 2015

LGTM

@mgol mgol self-assigned this Aug 19, 2015
@mgol mgol closed this in b7a7dea Sep 7, 2015
mgol pushed a commit that referenced this pull request Sep 7, 2015
@mr21 @mgol
Effects: Remove additional parameters of easings
41a04e5 
(cherry-picked from b7a7dea)

Fixes gh-2367
Closes gh-2376
@mgol
Copy link
Member

mgol commented Sep 7, 2015

Thanks, landed.

@markelog markelog mentioned this pull request Nov 16, 2015
Closed
@markelog markelog mentioned this pull request Dec 22, 2015
Closed
@leonard-thieu leonard-thieu mentioned this pull request Oct 11, 2018
Merged
7 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@mgol mgol

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mr21 @gibson042 @gnarf @mgol @timmywil @jquerybot