Package.json: Update license attribute #2330
Conversation
|
LGTM; this fixes #2331. |
Specifying the type and URL is deprecated: https://docs.npmjs.com/files/package.json#license http://npm1k.org/ Fixes gh-2331
|
Signed and fixed commit message |
|
Thanks. I'd wait with merging for a moment until the discussion at npm/npm#4473 settles. |
Well, the issue got locked with no good resolution (only a proposal to include license data to couchdb in npm/npm#4473 (comment)). Until that happens, personally, I'm going to use a deprecated format in my packages (prefer WTFPL license which npm website used to point to nowhere without an explicit link). Just tested, npm displays warning during development only, and won't affect users installing a package. So I guess ignoring it would be fine. |
|
@scottgonzalez What's your take on this? If we make this change, we should probably change it in all jQuery projects. |
|
I'm not a fan of the change, but there's no point in fighting it since npm isn't going to reverse this decision. I've filed https://github.com/npm/newww/issues/985 to get the proper links on the npm site. We should update all projects to conform to the new package.json spec. |
|
OK, I'm merging it then. |
Specifying the type and URL is deprecated: https://docs.npmjs.com/files/package.json#license http://npm1k.org/ (cherry-picked from 8e92e1e) Fixes gh-2331 Closes gh-2330
|
Landed; thanks @pgilad! |
|
👏 |
Specifying the type and URL is deprecated: https://docs.npmjs.com/files/package.json#license http://npm1k.org/ Fixes gh-2331 Closes gh-2330
specifying the type and URL is deprecated:
https://docs.npmjs.com/files/package.json#license
http://npm1k.org/