Event: Remove fake originalEvent from jQuery.Event.simulate #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect( 1 ); | ||
|
|
||
| var done = assert.async(), | ||
| input = jQuery( "<input>" ).appendTo( "#form" ); |
There was a problem hiding this comment.
Let's self-close the input for that XHTML support that we keep telling ourselves will be verified someday.
There was a problem hiding this comment.
Agreed for sanitation and sanity reasons, although this goes through the rsingleTag path anyway.
added 3 commits
May 14, 2015 00:53
Make sure preventing default on focusin thows no exception Make sure simulated event has no originalEvent Add test for jQuery.event.simulate() originally written by Dave Methvin at https://jsfiddle.net/74eutos8/embedded/result/
gabrielschulhof
force-pushed
the
2300-empty-originalEvent-gone
branch
from
2826dfc to
74e0e29
Compare
|
@arschmitz @timmywil the event-related breakage in the mobile tests ensues from the fact that we // mock originalEvent
$.Event.prototype.originalEvent = {
touches: [ { pageX: 0, pageY: 0 } ]
};... and stuff like that. If we mock |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-2300