-
Notifications
You must be signed in to change notification settings - Fork 20.6k
arraylike #2243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arraylike #2243
Conversation
@markelog i already set git config user.name and user.email, but label has not changed. |
Could you sign CLA? Preferably with your real name from which you authored proposed commit. |
@markelog I used my real name, and tried many times, or not, I don't know why CLA: Error |
That is probably because some of your commits are signed correctly others are not, could you squash them to one commit? |
Thanks, i squash them to one commit, but it is CLA: Error, I used my real name. |
@scottgonzalez could you help us out? |
Everything seems OK to me with your setup, @mhbseal. |
The CLA was originally signed all lowercase. I've updated the signature and deleted the several duplicate signatures. |
Should checker be case-insensitive?
bot was confused because of the duplicates? |
Potentially. I'd prefer if people just wrote their name properly.
Only the first signature is used. All future signatures are discarded. |
Maybe bot could collect all signatures and choose the right one with correct case? So we wouldn't confuse people when they correct their signature? |
This has been discussed to death. Please move any discussion to the appropriate repo. |
Thank you all |
More info at the issue: #2238