Skip to content

arraylike #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

arraylike #2243

wants to merge 1 commit into from

Conversation

mhbseal
Copy link
Contributor

@mhbseal mhbseal commented Apr 29, 2015

More info at the issue: #2238

@mhbseal
Copy link
Contributor Author

mhbseal commented Apr 29, 2015

@markelog i already set git config user.name and user.email, but label has not changed.

@mhbseal mhbseal mentioned this pull request Apr 29, 2015
@markelog
Copy link
Member

Could you sign CLA?

Preferably with your real name from which you authored proposed commit.

@mhbseal
Copy link
Contributor Author

mhbseal commented Apr 29, 2015

@markelog I used my real name, and tried many times, or not, I don't know why CLA: Error

@markelog
Copy link
Member

That is probably because some of your commits are signed correctly others are not, could you squash them to one commit?

@mhbseal
Copy link
Contributor Author

mhbseal commented Apr 30, 2015

Thanks, i squash them to one commit, but it is CLA: Error, I used my real name.

@markelog
Copy link
Member

@scottgonzalez could you help us out?

@mgol
Copy link
Member

mgol commented Apr 30, 2015

Everything seems OK to me with your setup, @mhbseal.

@scottgonzalez
Copy link
Member

The CLA was originally signed all lowercase. I've updated the signature and deleted the several duplicate signatures.

@markelog
Copy link
Member

@scottgonzalez

The CLA was originally signed all lowercase.

Should checker be case-insensitive?

I've updated the signature and deleted the several duplicate signatures.

bot was confused because of the duplicates?

@scottgonzalez
Copy link
Member

Should checker be case-insensitive?

Potentially. I'd prefer if people just wrote their name properly.

bot was confused because of the duplicates?

Only the first signature is used. All future signatures are discarded.

@markelog
Copy link
Member

Maybe bot could collect all signatures and choose the right one with correct case? So we wouldn't confuse people when they correct their signature?

@scottgonzalez
Copy link
Member

This has been discussed to death. Please move any discussion to the appropriate repo.

@mhbseal
Copy link
Contributor Author

mhbseal commented May 4, 2015

Thank you all

@timmywil timmywil closed this in 436f0ae May 5, 2015
timmywil pushed a commit that referenced this pull request May 5, 2015
markelog pushed a commit that referenced this pull request Nov 10, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants