Skip to content

Attr: remove unnecessary element null check #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
campersau wants to merge 1 commit into from
Closed

Attr: remove unnecessary element null check #2201

campersau wants to merge 1 commit into from

Conversation

@campersau
Copy link
Contributor

@campersau campersau commented Apr 13, 2015

because the nodeType property was already accessed and would have thrown an exception

Or should the elem null check go before reading the nodeType property?

@campersau
Attr: remove unnecessary element null check
bdf3ad9 
because the `nodeType` property was already accessed and would have thrown an exception
timmywil pushed a commit that referenced this pull request Apr 20, 2015
@campersau @timmywil
Attributes: remove unnecessary element null check
0de798d 
Close gh-2201
@timmywil timmywil closed this in 55ac56a Apr 20, 2015
@campersau campersau deleted the patch-1 branch April 20, 2015 19:10
@campersau campersau mentioned this pull request Jun 10, 2015
Closed
markelog pushed a commit that referenced this pull request Nov 10, 2015
@campersau @markelog
Attributes: remove unnecessary element null check
e50af14 
Close gh-2201
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@campersau @jquerybot