Data: Drop the tests relying on applets #2166
Conversation
| // Skip it on TestSwarm. | ||
| if ( location.search.indexOf( "swarmURL=" ) === -1 ) { | ||
| ok( jQuery.acceptData( document.createElement( "applet" ) ), "applet" ); | ||
| } |
There was a problem hiding this comment.
Don't do this; just drop the assertion unconditionally and let the preceding one cover it. See #1938 (comment) ("we don't need an applet or applet object") and observe that applet and embed get identical treatment:
Lines 242 to 249 in 7b11131
| @@ -773,7 +773,6 @@ test("jQuery.acceptData", 11, function() { | |||
| ok( jQuery.acceptData( document.documentElement ), "documentElement" ); | |||
| ok( jQuery.acceptData( {} ), "object" ); | |||
| ok( jQuery.acceptData( document.createElement( "embed" ) ), "embed" ); | |||
| ok( jQuery.acceptData( document.createElement( "applet" ) ), "applet" ); | |||
There was a problem hiding this comment.
Decrement the expected count to 10, then it's all set.
There was a problem hiding this comment.
OK, this time I run it and the tests pass. ;)
mgol
force-pushed
the
java
branch
2 times, most recently
from
3e28421 to
47860e1
Compare
|
@gibson042 I had to drop one other test that was creating an applet, can you have a look? All those tests are run on embed as well so it should be fine. I'm doing it all today in case of BrowserStack fixing this "Java out of date" bug so that I can be sure this time I've really fixed it. |
mgol
changed the title
BrowserStack regularly has outdated Java in their IE instances causing our data tests to hang & give no output. Skip the tests that create applets, applets are treated in the same way as an embed elements which we're already testing. Fixes jquerygh-1938 Closes jquerygh-2166
|
I landed this; I didn't want to wait as it was causing TestSwarm to continuously restart IE data tests. It worked: http://swarm.jquery.org/job/216. Cherry-picking in progress... |
BrowserStack regularly has outdated Java in their IE instances causing our data tests to hang & give no output. Skip the tests that create applets, applets are treated in the same way as an embed elements which we're already testing. (partially cherry-picked from a4a18e8) Fixes gh-1938 Refs gh-2028 Refs gh-2166
BrowserStack regularly has outdated Java in their IE instances causing our
data tests to hang & give no output. Skip the tests that create applets,
applets are treated in the same way as an embed elements which we're already
testing.
Fixes gh-1938
(note to myself: if accepted, remember to cherry-pick this to
2.1-stable&1.11-stabletogether with #2028)Original description:
BrowserStack regularly has outdated Java in their IE instances causing our
data tests to hang & give no output. Skip the assertion if the test is run
via TestSwarm.