Skip to content

Simplification of manipulation wrappers #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Simplification of manipulation wrappers #2032

wants to merge 1 commit into from

Conversation

markelog
Copy link
Member

Since support for IE6-7 was dropped these wrappers no longer required
Ref 90d7cc1
Fixes gh-2002

Note: if this would be merged, it would not auto-close #2002.
Should we mention "Fixes ..." for compat only commits?

@gibson042
Copy link
Member

Fixes gh-2002 will still be valuable for anyone looking at the commit in isolation, even if GitHub doesn't auto-close because it's against a non-master branch. We should keep the reference.

@markelog
Copy link
Member Author

We should keep the reference.

Didn't ask whether we need to keep the reference. Did ask about the way we need to store the ticket number. Ref, Fixes? Judging by guide neither of those are applicable.

I'd say Fixes even if github doesn't close anything.

@gibson042
Copy link
Member

I'd say Fixes even if github doesn't close anything.

I agree. Fixes gh-2002.

@dmethvin
Copy link
Member

Agreed. The statement is true even if Github doesn't close the ticket. In our case for cherry-picked commits that's fine since the one from master will close it. It's just the compat-only ones that we have to do the closing.

@markelog
Manipulation: simplification of manipulation wrappers
9f8c022 
Since support for IE6-7 was dropped these wrappers no longer required
Ref 90d7cc1
Fixes jquerygh-2002
markelog added a commit that referenced this pull request Feb 10, 2015
@markelog
Manipulation: simplification of manipulation wrappers
588da97 
Since support for IE6-7 was dropped these wrappers no longer required

Ref 90d7cc1
Ref gh-2002
Closes gh-2032
markelog added a commit that referenced this pull request Feb 10, 2015
@markelog
Manipulation: simplification of manipulation wrappers
3e87120 
Since support for IE6-7 was dropped these wrappers no longer required

Ref 90d7cc1
Ref gh-2002
Closes gh-2032
@markelog
Copy link
Member Author

Merged

@markelog markelog closed this Feb 10, 2015
@markelog markelog mentioned this pull request Dec 22, 2015
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markelog @gibson042 @dmethvin