Skip to content

Ajax: Run the PATCH test only in IE8 on TestSwarm #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2015

Conversation

mgol
Copy link
Member

@mgol mgol commented Jan 25, 2015

Fixes gh-1994

mgol added a commit to mgol/jquery that referenced this pull request Jan 25, 2015
mgol added a commit to mgol/jquery that referenced this pull request Jan 26, 2015
ok( false, "error" );
}
});
// BrowserStack PATCH support sometimes breaks so on TestSwarm run the test in IE8 only.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, so browserstack can't fix that issue huh? Would need to be careful here when we switch from testswarm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I've already exchanged 22 mails with BrowserStack people, the first one at the end of October. This problem disappears and then re-appears again after some time. I'd rather not spend more time on this so it's better to restrict this to IE8.

As for switching from TestSwarm: sure, though if we forget about it then nothing terrible will happen. We'll notice it the first time PATCH fails again. ;) And then we'll fix the exclusion logic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I've already exchanged 22 mails with BrowserStack people, the first one at the end of October. This problem disappears and then re-appears again after some time.

Yeah, i remember, what i fun read that is :-).

We'll notice it the first time PATCH fails again

Would be kind of weird of the bug, if by the time they fix that issue we leave the testswarm. Anyways, fully agree on the matter.

@mgol mgol changed the title Ajax: Run the PATCH test only in IE8 on build.jenkins.jquery.com Ajax: Run the PATCH test only in IE8 on TestSwarm Jan 29, 2015
@mgol mgol merged commit 2524da0 into jquery:compat Jan 29, 2015
@mgol mgol deleted the non-ie-PATCH branch January 29, 2015 03:35
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants