ajax: post and get accept config object [issue #1986] #1995
Conversation
|
I love it when someone delivers. 🌟 |
| url: url, | ||
| type: method, | ||
| dataType: type, | ||
| data: data, | ||
| success: callback | ||
| }); | ||
| }, (jQuery.isPlainObject(url) && url))); |
There was a problem hiding this comment.
Should be spaces inside the parens here per our style guide.
There was a problem hiding this comment.
Trying to find it in the style guide...you mean it should be ( jQuery.isPlainObject(url) && url )))?
There was a problem hiding this comment.
Although this allows a mixed call like $.ajax({ options }, data) I think we'd only want to document a single options object.
There was a problem hiding this comment.
( jQuery.isPlainObject( url ) && url ) ) )
There was a problem hiding this comment.
The outer parens aren't needed tho, right?
There was a problem hiding this comment.
No I don't think they're needed, just make it clearer that its a single expression. I'll remove. Agree about only documenting a single options object
|
@togakangaroo Be sure that you've signed our CLA, https://contribute.jquery.org/CLA/ |
|
@dmethvin I signed it, thanks |
|
I'm not super sure where/how to update the docs btw. Really mostly where |
| @@ -2034,6 +2034,25 @@ module( "ajax", { | |||
| }); | |||
| }); | |||
|
|
|||
| asyncTest( "jQuery[get|post]( config ) - simple with xml", 2, function() { | |||
| jQuery.when.apply(jQuery, | |||
There was a problem hiding this comment.
The same remark about spaces; there should be a space after (, [ and before ), ] etc.
|
I created jquery/api.jquery.com#620 , The docs are at http://github.com/jquery/api.jquery.com/#readme, they're processed from XML so you'll want to go through the setup listed there or pull down the preconfigured VM so that you can be sure the markup looks good. |
See this issue for more discussion.