Skip to content

Deferred: Fix $.when with resolved deferred and progress callbacks #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Deferred: Fix $.when with resolved deferred and progress callbacks #1915

wants to merge 1 commit into from

Conversation

nicolashenry
Copy link
Contributor

Fixes gh-1894

@dmethvin
Copy link
Member

dmethvin commented Dec 9, 2014

Hi @nicolashenry and thanks! Have you signed our CLA yet? I didn't see your name there.

@jaubourg
Copy link
Member

jaubourg commented Dec 9, 2014

There is a lack of spaces around arguments in function calls in the unit test. See the style guide. Other than that, it looks good to me!

@nicolashenry
Copy link
Contributor Author

@dmethvin , @jaubourg : Done!

@nicolashenry
Copy link
Contributor Author

I rebased the changes in order to have only one commit. Tell me if I forgot something else.

@dmethvin dmethvin added this to the 3.0.0 milestone Dec 10, 2014
@dmethvin dmethvin self-assigned this Dec 10, 2014
@markelog markelog closed this in ab20d9d Dec 25, 2014
@mgol mgol removed this from the 3.0.0 milestone Oct 17, 2015
markelog pushed a commit that referenced this pull request Nov 10, 2015
@nicolashenry @markelog
Deferred: Fix $.when with resolved deferred and progress callbacks
fb77e6e 
Fixes gh-1894
Closes gh-1915
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@dmethvin dmethvin

Labels
Deferred
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$.when, $.progress and already resolved deferred
4 participants
@nicolashenry @dmethvin @jaubourg @mgol