Bugfix for #15213: calling .empty() on disabled callbacks object kind of re-enables it #1643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lmost but not quite fully re-enable a disabled callbacks object.
|
Thanks for the PR! We'll want a few new unit tests to go with this as well. I'd want to test the case where there is an empty list, and one where there is already something in the list. Also be sure you've signed our CLA. |
|
@TheDistantSea Using an email address that won't deliver email isn't a valid way to sign the CLA. You also didn't provide your full name. |
|
@TheDistantSea It doesn't look like you've signed the CLA yet. Would you like credit for the fix? |
|
lgtm! |
dmethvin
added a commit
that referenced
this pull request
Dec 8, 2014
Thanks to @TheDistantSea for the report! Fixes gh-1790 Closes gh-1643 (cherry picked from commit bc1cb12)
|
@dmethvin I wasn't around and missed the action (in fact had forgotten about all this) but no complaints. Glad to have helped a little bit. |
dmethvin
added a commit
that referenced
this pull request
Nov 10, 2015
Thanks to @TheDistantSea for the report! Fixes gh-1790 Closes gh-1643
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying description from jQuery bug tracker:
Earlier today I answered this StackOverflow question, wherein this behavior is shown:
var c = $.Callbacks();
var f = /* some function */;
c.disable();
c.empty();
c.add(f);
c.disabled(); // of course true
c.fire(); // invokes f!
This behavior occurs in all versions of jQuery I tested (latest 1.9, 1.10, 1.11, 2.0, 2.1) -- here's a fiddle to easily reproduce it.
The problem is that .disable() relies on setting internal variables of the callbacks object to undefined, and while most other methods such as .add() test and this condition and abort if true, .empty() itself does not. Instead it resets some of those variables, which causes the abort test in the other methods to erroneously pass and ultimately for callbacks to be added to and invoked by a disabled object.