Fix #14180. Allow cross-frame attachment of focusin/out. #1369
Conversation
|
:-) |
|
Leaking memory in my 1.x-master test so I'll wait until after this beta |
(cherry picked from commit 6d5dfa0eda2c19e8838930fafff83b596654eca2) Manually edited for conflicts.
|
I think i figured out the problems here and am going to make another run at it. |
|
In my local branch this is passing all browsers but Opera 12. Swarmy is using Opera 12/15 as the versions but right now Opera is on 17 and I think we should not be running 12 at all anyway. There's perhaps a bit of controversy here because 12 is the last non-Blink version of Opera but given its low market share and the obscurity of this particular issue (cross-browser focus) I think it's fine that we dump Opera 12 Swarmy testing for now. Thoughts? |
|
@dmethvin I disagree about Opera 12.1x, it has a pretty large market share in a number of countries; in Poland it's 5-8%, in Russia even more. I think we should keep testing on that. I'm fine with blacklisting the nastiest test cases for this browser if that helps, though. |
|
The important part about Opera 12.1x is that it doesn't show the user in any way that it's not the latest version. If you do an update check manually in Opera 12.16, it says it's the newest version. Also, there is still no version of Opera Blink for Linux (they say the work is in progress). |
(cherry picked from commit ebdb467761d756d4e52608a0df4a4d9b17da8092) (conflicts with .data() resolved manually)
(cherry picked from commit 6d5dfa0eda2c19e8838930fafff83b596654eca2) Manually edited for conflicts.
(cherry picked from commit ebdb467761d756d4e52608a0df4a4d9b17da8092) (conflicts with .data() resolved manually)
3 participants
Cross-frame stuff in general makes me queasy but this seems to work. I tried several different ways but this seemed to gzip better.