Skip to content

Fix #13353; #13428; #14359: Better treatment of native-backed events (focus/blur/checkbox-click) #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gibson042 wants to merge 2 commits into from
Closed

Fix #13353; #13428; #14359: Better treatment of native-backed events (focus/blur/checkbox-click) #1367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92d58e3
Fix #13353; #13428: Keep trigger parameters for native-backed events
gibson042 Sep 14, 2013
8ad1f6a
Fix #14359: Honor namespaces in native-backed event handling
gibson042 Sep 17, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
204 changes: 132 additions & 72 deletions src/event.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,62 @@ function returnFalse() {
return false;
}

function safeActiveElement() {
try {
return document.activeElement;
} catch ( err ) { }
function wrapNative( el, type, onlyHandlers, noopHandler ) {
var buffer, active;

// Abort if we've already completed setup
if ( jQuery._data( el, type ) ) {
return false;
}

// If triggering, force setup through jQuery.event.add
if ( noopHandler ) {
return jQuery.event.add( el, type, noopHandler );
}

// Register the reentrant controller for all namespaces
jQuery.event.add( el, type + "._", function( event ) {
// If this is the outermost with-native-handlers event, fire a native one
if ( (event.isTrigger & 1) && !active ) {
// Remember provided arguments
buffer = active = slice.call( arguments );

// Go native!
try {
this[ type ]();

// Support: IE<9
// Handle error on focus to hidden element (#1486, #12518)
} catch ( e ) {
return;
}

// Outermost synthetic does not pass Go
event.stopImmediatePropagation();
event.preventDefault();

// Support: IE
// Asynchronous native focus/blur methods mean we can't forward the result;
// instead `buffer` will still hold the input arguments array
return buffer;

// If this is a native event from above, everything is now in order
// Fire an inner synthetic event with the original arguments
} else if ( !event.isTrigger && active ) {
// Buffer the "actual" result, using the original jQuery.Event to preserve namespaces
// Support: IE
// Extend with the prototype to reset the above stopImmediatePropagation()
buffer = jQuery.event.trigger( jQuery.extend( buffer.shift(), jQuery.Event.prototype ),
buffer, this, onlyHandlers );
active = false;

// Intermediate native does not pass Go
event.stopImmediatePropagation();
}
});

// Note that the intercepting handler exists, but don't abort .add
return !jQuery._data( el, type, true );
}

/*
Expand Down Expand Up @@ -382,20 +434,19 @@ jQuery.event = {
return;
}

// Determine handlers
// Determine and invoke handlers
handlerQueue = jQuery.event.handlers.call( this, event, handlers );

// Run delegates first; they may want to stop propagation beneath us
i = 0;
while ( (matched = handlerQueue[ i++ ]) && !event.isPropagationStopped() ) {
event.currentTarget = matched.elem;

j = 0;
while ( (handleObj = matched.handlers[ j++ ]) && !event.isImmediatePropagationStopped() ) {

// Triggered event must either 1) have no namespace, or
// 2) have namespace(s) a subset or equal to those in the bound event (both can have no namespace).
if ( !event.namespace_re || event.namespace_re.test( handleObj.namespace ) ) {
// Invoke handlers that match or contain all event namespaces
// Underscore-namespaced handlers always match
if ( handleObj.namespace === "_" ||
!event.namespace_re || event.namespace_re.test( handleObj.namespace ) ) {

event.handleObj = handleObj;
event.data = handleObj.data;
Expand Down Expand Up @@ -427,7 +478,7 @@ jQuery.event = {
delegateCount = handlers.delegateCount,
cur = event.target;

// Find delegate handlers
// Add delegate handlers first; they may want to stop propagation beneath us
// Black-hole SVG <use> instance trees (#13180)
// Avoid non-left-click bubbling in Firefox (#3861)
if ( delegateCount && cur.nodeType && (!event.button || event.type !== "click") ) {
Expand Down Expand Up @@ -516,6 +567,29 @@ jQuery.event = {
return fixHook.filter ? fixHook.filter( event, originalEvent ) : event;
},

simulate: function( type, elem, event, bubble ) {
// Piggyback on a donor event to simulate a different one.
// Fake originalEvent to avoid donor's stopPropagation, but if the
// simulated event prevents default then we do the same on the donor.
var e = jQuery.extend(
new jQuery.Event(),
event,
{
type: type,
isSimulated: true,
originalEvent: {}
}
);
if ( bubble ) {
jQuery.event.trigger( e, null, elem );
} else {
jQuery.event.dispatch.call( elem, e );
}
if ( e.isDefaultPrevented() ) {
event.preventDefault();
}
},

// Includes some event props shared by KeyEvent and MouseEvent
props: "altKey bubbles cancelable ctrlKey currentTarget eventPhase metaKey relatedTarget shiftKey target timeStamp view which".split(" "),

Expand Down Expand Up @@ -571,81 +645,67 @@ jQuery.event = {
// Prevent triggered image.load events from bubbling to window.load
noBubble: true
},
focus: {
// Fire native event if possible so blur/focus sequence is correct
trigger: function() {
if ( this !== safeActiveElement() && this.focus ) {
try {
this.focus();
return false;
} catch ( e ) {
// Support: IE<9
// If we error on focus to hidden element (#1486, #12518),
// let .trigger() run the handlers
}
}
},
delegateType: "focusin"
},
blur: {
trigger: function() {
if ( this === safeActiveElement() && this.blur ) {
this.blur();
return false;
}
},
delegateType: "focusout"
},
click: {
// For checkbox, fire native event so checked state will be right
trigger: function() {
if ( jQuery.nodeName( this, "input" ) && this.type === "checkbox" && this.click ) {
this.click();
return false;
}
},

// For cross-browser consistency, don't fire native .click() on links
_default: function( event ) {
return jQuery.nodeName( event.target, "a" );
}
},

beforeunload: {
postDispatch: function( event ) {

// Even when returnValue equals to undefined Firefox will still show alert
if ( event.result !== undefined ) {
event.originalEvent.returnValue = event.result;
}
}
}
},
},

simulate: function( type, elem, event, bubble ) {
// Piggyback on a donor event to simulate a different one.
// Fake originalEvent to avoid donor's stopPropagation, but if the
// simulated event prevents default then we do the same on the donor.
var e = jQuery.extend(
new jQuery.Event(),
event,
{
type: type,
isSimulated: true,
originalEvent: {}
click: {
// For cross-browser consistency, don't fire native .click() on links
_default: function( event ) {
return jQuery.nodeName( event.target, "a" );
},

// Utilize native event to ensure correct checkbox state
setup: function() {
// Claim the first click handler
if ( jQuery.nodeName( this, "input" ) && this.type === "checkbox" && this.click ) {
wrapNative( this, "click" );
}

// Nothing to see here, move along
return false;
},
trigger: function() {
// Force setup before triggering a click
if ( jQuery.nodeName( this, "input" ) && this.type === "checkbox" && this.click ) {
wrapNative( this, "click", false, returnTrue );
}
}
);
if ( bubble ) {
jQuery.event.trigger( e, null, elem );
} else {
jQuery.event.dispatch.call( elem, e );
}
if ( e.isDefaultPrevented() ) {
event.preventDefault();
}
}
};

// Utilize native events to ensure correct blur/focus sequence
jQuery.each( { focus: "focusin", blur: "focusout" }, function( type, delegateType ) {
jQuery.event.special[ type ] = {

delegateType: delegateType,

setup: function() {
// Claim the first click handler
return wrapNative( this, type, !support.focusinBubbles );
},

trigger: function() {
try {
// Force setup before trigger
if ( (this === document.activeElement) === (type === "blur") && this[ type ] ) {
wrapNative( this, type, !support.focusinBubbles, returnTrue );
}

// Support: IE9
// Iframes and document.activeElement don't mix well
} catch ( err ) {}
}
};
});

jQuery.removeEvent = document.removeEventListener ?
function( elem, type, handle ) {
if ( elem.removeEventListener ) {
Expand Down
Loading