Skip to content

Conversation

@gibson042
Copy link
Member

It's big, but much better than gibson042@80789b1... and this brings the count of fixed bugs up to 3, further reducing the added size per fix! 😉

At any rate, I also found some possible optimizations in event.js that I'll be exploring once this PR closes either way.

raw gz Compared to 1.x-master @ fd29642

 +2073   +586 dist/jquery.js
  +484   +103 dist/jquery.min.js

@dmethvin
Copy link
Member

I have a theory that the people who use the data parameter, or who use a namespace for manually triggering, could just go through the old-style path rather than using a natively triggered event method. That's what they did until I tried to fix it a few versions back. I just can't imagine that fixing these specific cases is worth 484 bytes gzip.

@gibson042
Copy link
Member Author

Don't you mean +103? Anyway, you may be right but I don't know how to confirm... it just rubs me the wrong way that we went to so much trouble fixing these events in particular to match native behavior and ended up breaking our own internal consistency.

@gibson042
Copy link
Member Author

@dmethvin
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants