Skip to content

No ticket: remove selector and context properties #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gibson042
Copy link
Member

As far as I can tell, the context property of jQuery collections exists only to let jquery-migrate monkey-patch .live and .die, and selector is completely unnecessary. We should move necessary code into that plugin and cut our undocumented ties with the past.

   raw     gz Sizes
271181  80511 dist/jquery.js
 92655  32561 dist/jquery.min.js

   raw     gz Compared to 1.x-master @ 4f786ba4d2a5544cb48f589d2659d6cab84efc34
  -477   -140 dist/jquery.js
  -213    -86 dist/jquery.min.js

@mgol
Copy link
Member

mgol commented Apr 20, 2013

Well, at least selector is deprecated but no such info about context.

Also, is it sth that's easy to add to jQuery Migrate? I thought that's the reason they still exist that it would be hard to cleanly add them as a plugin.

@rwaldron
Copy link
Member

@gibson042
Copy link
Member Author

OMFG.

@gibson042 gibson042 closed this Apr 20, 2013
@gibson042
Copy link
Member Author

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants