Using "hasOwnProperty" to check for direct properties "type" and #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"namespace" on events before triggering.
Member
|
@rwldrn I just took care of the whitespace/quotes myself and made a couple of tweaks. Thanks for pointing em out tho. @andrewplummer http://contribute.jquery.org/style-guide/js/ |
gnarf
pushed a commit
that referenced
this pull request
Jan 31, 2013
Squashed commit of the following: commit 5935a36 Author: Andrew Plummer <[email protected]> Date: Fri Feb 1 02:40:42 2013 +0900 Using "hasOwnProperty" to check for direct properties "type" and "namespace" on events before triggering.
Member
|
Landed in 1.9-stable and master. |
Contributor
Author
|
@gnarf37 thank you! Sorry, force of habit. |
Member
|
⭐ Thanks for being persistant, and listening, and above all the contribution. ⭐ 👍 |
Contributor
Author
|
Of course! In a sense I'm asking for a lot, I realize that. |
mescoda
pushed a commit
to mescoda/jquery
that referenced
this pull request
Nov 4, 2014
…rygh-1153 Squashed commit of the following: commit 5935a36 Author: Andrew Plummer <[email protected]> Date: Fri Feb 1 02:40:42 2013 +0900 Using "hasOwnProperty" to check for direct properties "type" and "namespace" on events before triggering.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same change as #1140, minus a few back and forth commits that were reverted, and with a simpler unit test, as per @gnarf37's request.