2.0: Refactor jQuery.clean #1117
Closed
+57
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
In migrate plugin, jQuery.clean = function( elems, context, fragment, scripts, selection ) {
var newFragment = jQuery.buildFragment( elems, context || document, scripts, selection );
if ( fragment ) {
fragment.appendChild( newFragment );
} else {
fragment = newFragment;
}
return jQuery.merge( [], fragment.childNodes );
};But i did not test this code thoroughly |
src/manipulation.js
Outdated
Member
Member
Author
There was a problem hiding this comment.
done, it saves 15 bytes or so and it definitely looks more elegant.
src/manipulation.js
Outdated
Contributor
There was a problem hiding this comment.
Could you use also core_push here? Or maybe push instead of core_push in L446?
dmethvin
added a commit
that referenced
this pull request
Jan 8, 2013
Member
gibson042
pushed a commit
that referenced
this pull request
Jan 9, 2013
gibson042
added a commit
that referenced
this pull request
Jan 9, 2013
gibson042
pushed a commit
that referenced
this pull request
Jan 9, 2013
(cherry picked from commit 8e6c1ba)
mescoda
pushed a commit
to mescoda/jquery
that referenced
this pull request
Nov 4, 2014
mescoda
pushed a commit
to mescoda/jquery
that referenced
this pull request
Nov 4, 2014
(cherry picked from commit 8e6c1ba)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, when manipulation module was reduced, maybe it's time to refactor some stuff?
You removed
jQuery.buildFragment, but it seemsjQuery.cleanis one that should be removed. If this changes is acceptable i could ported it to 1.9 too.