Fix #13044: execute all QUnit modules in TestSwarm #1074
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
May wanna use something like this instead:
grunt.file.expandFiles( "test/unit/*.js" ).map(function ( path ) {
return path.match( /^test\/unit\/(.+)\.js$/)[1];
});
Member
Author
There was a problem hiding this comment.
It'd be a bigger change that way, and I wanted to keep this one super simple. The other tasks all expandFiles inside the task function, and I wasn't sure how deliberate that is.
Member
There was a problem hiding this comment.
I'd be okay with a more general solution.
Member
Author
|
@jquerybot retest |
1 similar comment
Member
Author
|
@jquerybot retest |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.