Refactor timer initialization, ticket #12837 #1021
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each step of each animation should not need to check
fxNow. Instead, the time can be queried once at the beginning ofjQuery.fx.tick. This also solves an iPad bug where an event for clearingfxNowwas being dropped, resulting in a never-ending animation.Note that the new unit test passes both before and after my patch is applied. The only way to exercise the bug is if the user is in Safari and pinches to zoom a colorbox before the animation starts. The test is probably still useful for verifying that synchronized animations work as advertized.
This is a continuation of pull request #1015.
/cc @gibson042 @gnarf37