Skip to content

Fix #12840: remove undocumented parameter "pass" from attr #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gibson042 wants to merge 2 commits into from
Closed

Fix #12840: remove undocumented parameter "pass" from attr #1017

gibson042 wants to merge 2 commits into from

Conversation

@gibson042
Copy link
Member

@gibson042 gibson042 commented Nov 4, 2012

Sizes - compared to master @ 53cb49c

    266788       (+71)  dist/jquery.js                                         
     93099       (-24)  dist/jquery.min.js                                     
     33165       (-63)  dist/jquery.min.js.gz

gibson042
gibson042 reviewed Nov 4, 2012
View reviewed changes
test/unit/attributes.js
Copy link
Member Author

@gibson042 gibson042 Nov 4, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why we were testing an undocumented interface.

@gibson042 gibson042 closed this in 80d45a6 Nov 5, 2012
mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@gibson042
Fix #12840: remove undocumented parameter "pass" from .attr. Close jq…
3ba2c8b 
…uerygh-1017.
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gibson042 @timmywil