Skip to content

Fix #4262: faster .eq #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gibson042 wants to merge 1 commit into from
Closed

Fix #4262: faster .eq #1000

gibson042 wants to merge 1 commit into from

Conversation

@gibson042
Copy link
Member

@gibson042 gibson042 commented Oct 19, 2012

http://jsperf.com/jq-eq-index-vs-jq-jqobj-index/2

Sizes - compared to master @ c6cf30a

    267495      (-107)  dist/jquery.js                                         
     94033       (-29)  dist/jquery.min.js                                     
     33616       (-20)  dist/jquery.min.js.gz

gibson042
gibson042 reviewed Oct 19, 2012
View reviewed changes
test/unit/core.js
Copy link
Member Author

@gibson042 gibson042 Oct 19, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.selector is going away in 1.9, right?

Copy link
Member

@dmethvin dmethvin Oct 19, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's being severely curtailed. All the junk in pushStack will go away and only the $() constructor will set .selector. That lets $(selector).live( ... ) still work but saves us a bunch of bytes in manipulation.js

@gibson042 gibson042 closed this in b5084b4 Oct 20, 2012
@dmethvin
Copy link
Member

dmethvin commented Oct 20, 2012

Inner monologue: "Is that ticket number right? It can't be right. Huh. February 2009."

@dmethvin
Copy link
Member

dmethvin commented Oct 20, 2012

BTW I rescued about half the selector tests for now, at least until the pushStack calls are stripped down.

@gibson042
Copy link
Member Author

gibson042 commented Oct 20, 2012

No worries; I wouldn't have touched them at all except that one failed, and then my delete finger got a bit itchy. As for the age of this ticket, thank @ajpiano for the love. :)

@ajpiano
Copy link
Member

ajpiano commented Oct 20, 2012

Heh, yeah, was catching up on Trac comments post-summit and saw this and I was like, hmm that's funky, didn't want to let it slip!! Thanks @gibson042

@ricardobeat
Copy link

ricardobeat commented Dec 14, 2012

four years ago O.o

mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@gibson042 @dmethvin
Fix jquery#4262: faster .eq(), closes jquerygh-1000.
f8c416b
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gibson042 @dmethvin @ajpiano @ricardobeat