IE & Edge crash with "Permission denied" on the `contents() for <frame />` test #4441

mgol · 2019-07-29T20:02:23Z

Description

IE 11 as well as Edge (even 17-18) often crash on the traversing: contents() for <frame /> test with the "Permission denied" error. IE crashes way often than Edge. This is probably related to my Sizzle removal PR (#4395) but I wasn't able to pinpoint the exact reason so far. The error points to line 174 in src/selector.js. An example failing run: http://swarm.jquery.org/result/3337866.

It's hard to debug as it's clearly a race condition. If I run this test in isolation, it always passes.

I think I've seen a similar failure on the 3.4-stable branch as well but it was happening way less often.

We should figure this out before the 4.0.0 release.

Link to test case

N/A, it's a core test already in the repo.

The text was updated successfully, but these errors were encountered:

mgol · 2019-08-05T17:02:56Z

Unfortunately, while in the vast majority of cases the test case fails in IE, when you run that particular test in isolation it almost never fails. This makes debugging tricky.

mgol · 2019-08-12T21:20:59Z

Some conclusions from my investigation:

The error is triggered by this line:

var contents = container.find( "#test-frame" ).contents();

This is not the only test failing with "Permission denied". I initially thought this one failure triggers more of them sometimes but commenting out that one test results in frequent failures in some other tests, e.g. the traversing: sort direction test. The stack trace doesn't point to anything that could help.

mgol · 2019-08-26T23:36:46Z

I found the cuplrit. IE/Edge sometimes crash when comparing documents between frames... but only if one of the strict equality operators (=== or !==) is used. Shallow equivalents (== or !=) work fine... PR incoming.

This means the issue might as well exist on 3.x as well, maybe it just triggers the condition less often. I'm changing the milestone to 3.4.2 & I'll submit a PR to Sizzle as well.

…crashes IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Fixes jquerygh-4441

mgol · 2019-08-26T23:42:29Z

jQuery PR (for jQuery 4.0): #4471.

…crashes IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Fixes jquerygh-4441

mgol · 2019-08-26T23:48:59Z

Note to self: reopen issue after landing #4471 so that a Sizzle PR also lands.

…crashes IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Fixes jquerygh-4441

IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Fixes gh-4441 Closes gh-4471

mgol · 2019-09-24T22:41:40Z

Reopening as we still need to land a fix in Sizzle & then update Sizzle on the ~~3.4-stable~~ 3.x-stable branch.

IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. The change to shallow comparisons in `src/selector.js` was done in jquerygh-4471 but relevant changes in `src/selector/uniqueSort.js` were missed. Fixes jquerygh-4441 Closes jquerygh-4471

IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Fixes jquery/jquery#4441 Closes jquery/jquery#4471

mgol · 2019-09-26T21:02:03Z

Sizzle PR: jquery/sizzle#459.

IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Fixes jquery/jquery#4441 Closes jquery/jquery#4471

mgol · 2019-10-01T00:39:41Z

Re-opening as we still need a new Sizzle with the fix for jQuery 3.x. The Sizzle PR: jquery/sizzle#459 has been merged.

IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. The change to shallow comparisons in `src/selector.js` was done in jquerygh-4471 but relevant changes in `src/selector/uniqueSort.js` were missed. Fixes jquerygh-4441 Closes jquerygh-4471

mgol · 2019-10-10T23:07:54Z

Reopening since we still need to update Sizzle in jQuery 3.x.

IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. The change to shallow comparisons in `src/selector.js` was done in jquerygh-4471 but relevant changes in `src/selector/uniqueSort.js` were missed. Fixes jquerygh-4441 Closes jquerygh-4471

IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. The change to shallow comparisons in `src/selector.js` was done in jquerygh-4471 but relevant changes in `src/selector/uniqueSort.js` were missed. Those changes have landed in Sizzle in jquery/sizzle#459. Fixes jquerygh-4441 Closes jquerygh-4471 Ref jquery/sizzle#459

IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. The change to shallow comparisons in `src/selector.js` was done in gh-4471 but relevant changes in `src/selector/uniqueSort.js` were missed. Those changes have landed in Sizzle in jquery/sizzle#459. Fixes gh-4441 Closes gh-4512 Ref gh-4471 Ref jquery/sizzle#459

Fixes jquerygh-4424 Fixes jquerygh-4435 Fixes jquerygh-4441 Fixes jquerygh-4453

Fixes gh-4424 Fixes gh-4435 Fixes gh-4441 Fixes gh-4453 Closes gh-4641

mgol · 2020-03-16T16:35:44Z

Sizzle update merged in #4641. The issue is now fixed both on master & on 3.x-stable.

IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Ref jquerygh-4441 Ref jquerygh-4471 Ref jquery/sizzle#459

mgol added Bug Selector Traversing Blocker labels Jul 29, 2019

mgol added this to the 4.0.0 milestone Jul 29, 2019

mgol changed the title ~~IE & Edge often crash on the contents() for <frame /> test~~ IE & Edge crash with "Permission denied" on the contents() for <frame /> test Aug 5, 2019

mgol modified the milestones: 4.0.0, 3.4.2 Aug 26, 2019

mgol mentioned this issue Aug 26, 2019

Selector: Use shallow document comparisons to avoid IE/Edge crashes #4471

Merged

2 tasks

mgol added the Has Pull Request label Aug 26, 2019

mgol closed this as completed in #4471 Sep 24, 2019

mgol reopened this Sep 24, 2019

mgol mentioned this issue Sep 26, 2019

Selector: Use shallow document comparisons to avoid IE/Edge cras… jquery/sizzle#459

Merged

mgol added the Needs review label Sep 26, 2019

mgol reopened this Oct 1, 2019

mgol added the Awaiting Sizzle Update label Oct 1, 2019

mgol removed Has Pull Request Needs review labels Oct 1, 2019

mgol closed this as completed in mgol/sizzle@cd0239b Oct 1, 2019

mgol reopened this Oct 10, 2019

mgol mentioned this issue Oct 14, 2019

Selector: Use shallow document comparisons in uniqueSort #4512

Merged

4 tasks

mgol closed this as completed in #4512 Oct 21, 2019

mgol reopened this Oct 21, 2019

mgol added a commit to mgol/jquery that referenced this issue Mar 14, 2020

Selector: Update Sizzle from 2.3.4 to 2.3.5

35f404d

Fixes jquerygh-4424 Fixes jquerygh-4435 Fixes jquerygh-4441 Fixes jquerygh-4453

mgol mentioned this issue Mar 14, 2020

Selector: Update Sizzle from 2.3.4 to 2.3.5 #4641

Merged

2 tasks

mgol added a commit that referenced this issue Mar 16, 2020

Selector: Update Sizzle from 2.3.4 to 2.3.5

04bf577

Fixes gh-4424 Fixes gh-4435 Fixes gh-4441 Fixes gh-4453 Closes gh-4641

mgol removed the Awaiting Sizzle Update label Mar 16, 2020

mgol closed this as completed Mar 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IE & Edge crash with "Permission denied" on the `contents() for <frame />` test #4441

IE & Edge crash with "Permission denied" on the `contents() for <frame />` test #4441

mgol commented Jul 29, 2019 •

edited

Loading

mgol commented Aug 5, 2019

mgol commented Aug 12, 2019

mgol commented Aug 26, 2019

mgol commented Aug 26, 2019

mgol commented Aug 26, 2019

mgol commented Sep 24, 2019 •

edited

Loading

mgol commented Sep 26, 2019

mgol commented Oct 1, 2019

mgol commented Oct 10, 2019

mgol commented Mar 16, 2020

IE & Edge crash with "Permission denied" on the contents() for <frame /> test #4441

IE & Edge crash with "Permission denied" on the contents() for <frame /> test #4441

Comments

mgol commented Jul 29, 2019 • edited Loading

Description

Link to test case

mgol commented Aug 5, 2019

mgol commented Aug 12, 2019

mgol commented Aug 26, 2019

mgol commented Aug 26, 2019

mgol commented Aug 26, 2019

mgol commented Sep 24, 2019 • edited Loading

mgol commented Sep 26, 2019

mgol commented Oct 1, 2019

mgol commented Oct 10, 2019

mgol commented Mar 16, 2020

IE & Edge crash with "Permission denied" on the `contents() for <frame />` test #4441

IE & Edge crash with "Permission denied" on the `contents() for <frame />` test #4441

mgol commented Jul 29, 2019 •

edited

Loading

mgol commented Sep 24, 2019 •

edited

Loading