Skip to content

jQuery.Event( src ) cannot require src.target #3139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmethvin opened this issue Jun 2, 2016 · 2 comments
Closed

jQuery.Event( src ) cannot require src.target #3139

dmethvin opened this issue Jun 2, 2016 · 2 comments
Assignees
@dmethvin
Labels
Bug Event Has Pull Request
Milestone
3.0.0

Comments

@dmethvin
Copy link
Member

dmethvin commented Jun 2, 2016

If you construct a jQuery.Event( src ) using something that has src.type, the 3.0 code will die if there is not an src.target property. jQuery Mobile uses a pattern where they construct an object and then set properties like target afterwards, which was allowed by 1.x/2.x, so we need to fix this as a regression.
@dmethvin dmethvin added this to the 3.0.0 milestone Jun 2, 2016
@dmethvin dmethvin self-assigned this Jun 2, 2016
@dmethvin
Copy link
Member Author

dmethvin commented Jun 2, 2016

/cc @arschmitz

dmethvin added a commit to dmethvin/jquery that referenced this issue Jun 2, 2016
@dmethvin
Event: Allow constructing a jQuery.Event without a target
cd7d817 
Fixes jquerygh-3139
@dmethvin dmethvin mentioned this issue Jun 2, 2016
Closed
4 tasks
@arschmitz
Copy link
Member

@dmethvin ah thanks yeah i was having trouble figuring out exactly where this error was coming from

@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmethvin dmethvin

Labels
Bug Event Has Pull Request
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Event: Allow constructing a jQuery.Event without a target dmethvin/jquery
3 participants
@dmethvin @arschmitz @mgol