Skip to content

$.when( deferred ).done() (serious?) regression #3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmethvin opened this issue Mar 30, 2016 · 0 comments
Closed

$.when( deferred ).done() (serious?) regression #3029

dmethvin opened this issue Mar 30, 2016 · 0 comments
Assignees
@gibson042
Labels
Blocker Deferred Has Pull Request
Milestone
3.0.0

Comments

@dmethvin
Copy link
Member

This was discussed on IRC but it doesn't look like a code ticket was created. There is one for the docs at jquery/api.jquery.com#904 because the example in $.when() is pretty bad, but the main problem is that .done() now gets an array instead of individual args.

Repro here: http://jsbin.com/civaxelixa/edit?html,console

Marking this as a blocker for the moment.
@dmethvin dmethvin added this to the 3.0.0 milestone Mar 30, 2016
@dmethvin dmethvin mentioned this issue Apr 4, 2016
Closed
This was referenced Apr 15, 2016
Closed
Closed
gibson042 added a commit to gibson042/jquery that referenced this issue Apr 26, 2016
@gibson042
Deferred: Separate the two paths in jQuery.when
fca4a6a 
Single- and no-argument calls act like Promise.resolve.
Multi-argument calls act like Promise.all.

Fixes jquerygh-3029
gibson042 added a commit to gibson042/jquery that referenced this issue Apr 27, 2016
@gibson042
Deferred: Separate the two paths in jQuery.when
6af17b9 
Single- and no-argument calls act like Promise.resolve.
Multi-argument calls act like Promise.all.

Fixes jquerygh-3029
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gibson042 gibson042

Labels
Blocker Deferred Has Pull Request
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@dmethvin @timmywil @gibson042