Skip to content

Revert Ajax behavior change in 1.12.2 #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
timmywil opened this issue Mar 21, 2016 · 3 comments
Closed

Revert Ajax behavior change in 1.12.2 #3011

timmywil opened this issue Mar 21, 2016 · 3 comments
Labels
1.x-only Ajax
Milestone
1.12.3/2.2.3

Comments

@timmywil
Copy link
Member

See #2432 (comment)

This XSS update is a behavior change. We reverted in 2.2-stable, but not in 1.12-stable. It should stay in 3.0.
@timmywil timmywil added this to the 1.12.3/2.2.3 milestone Mar 21, 2016
@mgol mgol mentioned this issue Mar 21, 2016
Closed
mgol added a commit that referenced this issue Mar 23, 2016
@mgol
Revert "Ajax: Mitigate possible XSS vulnerability"
cfe830e 
This reverts commit f60729f.

Fixes gh-3011
Refs ad358fd
@mgol
Copy link
Member

mgol commented Mar 23, 2016

Fixed by cfe830e.

@mgol mgol closed this as completed Mar 23, 2016
@VanessaHenderson
Copy link

So are you leaving 1.12.0, 1.12.1, 1.12.2 with the fix despite it being a breaking change? Or are there plans on re-releasing those version without the fix?

@dmethvin
Copy link
Member

Once a version is released, we can't change it. We can only release new versions.

@raesene raesene mentioned this issue Apr 4, 2016
Closed
@lagar84 lagar84 mentioned this issue Mar 27, 2017
Closed
msmolka referenced this issue Jun 6, 2018
@markelog
Ajax: Mitigate possible XSS vulnerability
f60729f 
Proposed by @jaubourg

Cherry-picked from b078a62
Fixes gh-2432
Closes gh-2588
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
1.x-only Ajax
Milestone
1.12.3/2.2.3
Development

No branches or pull requests
4 participants
@dmethvin @timmywil @mgol @VanessaHenderson