Skip to content

Cannot set val() for select options containing tabs (\t) #2978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
carols10cents opened this issue Mar 8, 2016 · 4 comments
Closed

Cannot set val() for select options containing tabs (\t) #2978

carols10cents opened this issue Mar 8, 2016 · 4 comments
Assignees
@timmywil
Labels
Attributes Has Pull Request
Milestone
1.12.2/2.2.2

Comments

@carols10cents
Copy link

I have a select element that contains options whose values contain tab characters. My original use case was a trailing tab (string\t), but I've also tested with leading tabs (\tstring) and tabs in the middle of non-whitespace (str\ting).

I called .val('value with tab') on the select element and expected the corresponding option to be selected since the values are identical, but no option is selected.

A few interesting observations:

  • I can work around this issue for the leading and trailing cases by removing the leading or trailing tab characters from the string I pass to .val(), but this is unexpected since the values don't match exactly.
  • Removing a middle tab character and passing that to .val() does not select the value, so there is no workaround for strings that have tab characters in the middle.
  • The behavior is the same with jquery 2.2.1, 3.0.0-alpha1 and edge.
  • With jquery 1.12.1, the leading and trailing tabs have the bug behavior but having a tab in the middle of the word and passing a matching string with a tab in the middle works as expected, so there was a regression at some point in this case.

JSFiddle: https://jsfiddle.net/onnucjx7/2/ You'll see in the console what I expect the behavior to be compared to what the behavior actually is.

I searched for "tab" and "whitespace" and didn't see anything directly relevant; I did find this issue #1902 but it only mentions IE10 and I am seeing the unexpected behavior in Firefox 44 and Chrome 48.
@dmethvin
Copy link
Member

dmethvin commented Mar 8, 2016

Yeah, this bug fix seems responsible. Here's the PR and discussion. If we pull out that fix it seems like the code you're trying to use may not work on IE9 or 10, but then again we seem to have broken it consistently everywhere with this.

@gibson042
Copy link
Member

Actually, it looks to me like f6302b0 was overzealous in expanding 541e734 to include trimming of values rather than just text. I think a partial revert is in order.

@timmywil timmywil added this to the 1.12.2/2.2.2 milestone Mar 8, 2016
@mgol
Copy link
Member

mgol commented Mar 9, 2016

Is it really broken, though? From what I see we do the same that Chrome/Firefox does with one exception that we return null when no value is selected instead of an empty string: https://jsfiddle.net/m_gol/onnucjx7/3/

@gibson042
Copy link
Member

I think your fiddle is broken with respect to my comment (what's with the val attributes and replaced whitespace?). Focusing on value, I see the same behavior in Chrome, Firefox, and Edge: https://jsfiddle.net/onnucjx7/4/

All three are defining the value IDL attribute as a stripped and collapsed whitespace version of the content attribute, treating it like text instead of following the spec.
EDIT: The browsers are fine; this is jQuery's fault. I forgot that the <option> valHook getter is also used in the <select> valHook getter.

Fixing this should consist of updating the <option> valHook to return elem.value directly when it is correct, and otherwise performing the full strip and collapse whitespace operation (which requires more than jQuery.trim) upon jQuery.text( elem ).

@timmywil timmywil self-assigned this Mar 9, 2016
timmywil added a commit to timmywil/jquery that referenced this issue Mar 15, 2016
@timmywil
Attributes: strip/collapse whitespace for set values on selects
7e0e730 
Fixes jquerygh-2978
@timmywil timmywil mentioned this issue Mar 15, 2016
Closed
timmywil added a commit that referenced this issue Mar 17, 2016
@timmywil
Attributes: strip/collapse whitespace for set values on selects
e7af951 
Fixes gh-2978
Close gh-3002
timmywil added a commit that referenced this issue Mar 17, 2016
@timmywil
Attributes: strip/collapse whitespace for set values on selects
da015d9 
Fixes gh-2978
Close gh-3002
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timmywil timmywil

Labels
Attributes Has Pull Request
Milestone
1.12.2/2.2.2
Development

No branches or pull requests
5 participants
@dmethvin @timmywil @carols10cents @gibson042 @mgol