-
Notifications
You must be signed in to change notification settings - Fork 20.6k
jquery 2.2.1 breaks webpack builds when loading individual modules #2945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Indeed, experiencing the same thing here. Should be possible to add some alias to the config to fix it, but would indeed be much better if jquery just loaded 'sizzle' so that webpack can fetch it from the node_modules folder or wherever it is resolving from. |
It seems we should have included |
yup, |
We'll include this fix in 1.12.2/2.2.2. |
Thank you! |
What's the fix for this? I find that the version 1.12.2 and 2.2.2 is still not available in CDN (https://code.jquery.com/jquery/). |
2.2.0 is working for me... |
We'll discuss it on Monday. We might need to fix more things and we don't want to release every few days. |
Thanks @bertez . It worked for me. I used jquery v2.2.0 and sizzle v2.3.0. |
mmh, just installed 1.12.3 and still got this error; after adding an external folder etc it worked. |
This doesn’t appear to be fixed. I’m getting this error w/ 2.2.2 and 2.2.3:
The reference is to
|
Yeah, this was not fixed correctly. Everything from the Reopening & marking as a blocker. |
It'd be good to have a way of testing if the final structure is OK. |
I thought it was working, but maybe my local copy was wrong. It's tough to make an automated test because it's going through jquery-release. But, once it's working, we shouldn't have to touch it again. |
Same problem here:
When I copied the content of sizzle/dist to external/zizzle/dist, it compiled ok. |
The latest uncompressed jQuery worked here with Webpack after adding |
same problem here, ERROR in ./~/jquery/src/selector-sizzle.js |
We will have a fix in the next patch. Please use GitHub's reaction feature on the original post if you're having the same issue. |
Hi,
after this change 5943f1d webpack builds are broken when loading individual modules:
ERROR in ./~/jquery/src/selector-sizzle.js Module not found: Error: Cannot resolve 'file' or 'directory' ../external/sizzle/dist/sizzle in /Users/berto/Temp/webpack-jquery/node_modules/jquery/src @ ./~/jquery/src/selector-sizzle.js 1:0-14:3
I think this is happening because in 2.2.1 'selector-sizzle.js' is trying to load the sizzle dependency as '../external/sizzle/dist/sizzle' a file which does not exist, unlike in 2.2.0 (for instance) which loads 'sizzle'.
I set up a simple example here: https://github.com/bertez/webpack-jquery
Thank you very much in advance.
The text was updated successfully, but these errors were encountered: