-
Notifications
You must be signed in to change notification settings - Fork 20.6k
.prop("selected", true) does not work as expected in IE11 #2732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
To remove a red herring here, the special characters in the values don't change the outcome. Here is a simpler case, with the last selection changing the text to show that it was able to select the right element: http://jsfiddle.net/zksm1o5q/5/ Here's a bare DOM example without jQuery that exhibits the same problem: http://jsfiddle.net/15ytbys8/ |
This is a browser bug, but perhaps we should work around it in a propHook that sets all other option elements' selected values to |
Does that fix the problem? Is it only a bug with options that exist in the select already, or would we also need to guard against ones appended from elsewhere? This seems to work on Edge so it's only IE11 (and older IEs) affected. In any event it seems like that might really be a performance killer, especially on selects with a lot of options. I guess it could be limited by a feature detect to only IE and only when changing the |
What about setting |
That wouldn't be a big perf hit – or code size hit – and it seems to work: http://jsfiddle.net/timmywil/15ytbys8/1/. |
I don't think |
Yeah if that works it sounds pretty good. So if we're setting selected on an |
This is a non-breaking change; should we backport it to |
By selecting option with .prop("select", true), the behavior is not as expected under IE11
Testing with Firefox / Chrome / Safari, the behavior should be consistent,
the following example should have "Two" being selected:
http://jsfiddle.net/zksm1o5q/2
In IE, however, the result is "Four".
You may comment out Line 11, 12, and/or 14 for more test cases with expected result (last prop being selected) in other browsers, but IE11.
The text was updated successfully, but these errors were encountered: