Skip to content

Change licenses to license in package.json, follow the SPDX format #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgol opened this issue May 19, 2015 · 3 comments
Closed

Change licenses to license in package.json, follow the SPDX format #2331

mgol opened this issue May 19, 2015 · 3 comments
Assignees
@mgol
Labels
Build
Milestone
1.12.0/2.2.0

Comments

@mgol
Copy link
Member

mgol commented May 19, 2015

npm 2.10.0 now warns when running npm install in the jQuery repo as the licenses field is deprecated:

$ npm i
npm WARN package.json jquery@3.0.0-pre No license field.

We should be using the license field in the SPDX format that npm has started to check recently; see: https://docs.npmjs.com/files/package.json#license
@mgol mgol self-assigned this May 19, 2015
@mgol mgol added this to the 3.0.0 milestone May 19, 2015
@mgol mgol added the Build label May 19, 2015
@mgol
Copy link
Member Author

mgol commented May 19, 2015

@timmywil are there any changes necessary apart from modifying package.json so that it works with the release script?

@timmywil
Copy link
Member

Nope, that should be sufficient. package.json is copied by the release script.

@mgol mgol mentioned this issue May 19, 2015
Closed
@SimenB
Copy link

SimenB commented May 19, 2015

(You have a PR for this #2330)

@mgol mgol mentioned this issue May 19, 2015
Closed
@mgol mgol closed this as completed in 8e92e1e Jun 1, 2015
mgol pushed a commit that referenced this issue Jun 1, 2015
@pgilad @mgol
Build: Update the license attribute
8bf81d7 
Specifying the type and URL is deprecated:

https://docs.npmjs.com/files/package.json#license
http://npm1k.org/

(cherry-picked from 8e92e1e)

Fixes gh-2331
Closes gh-2330
markelog pushed a commit that referenced this issue Nov 10, 2015
@pgilad @markelog
Build: Update the license attribute
6a267f6 
Specifying the type and URL is deprecated:

https://docs.npmjs.com/files/package.json#license
http://npm1k.org/

Fixes gh-2331
Closes gh-2330
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
Build
Milestone
1.12.0/2.2.0
Development

No branches or pull requests
4 participants
@dmethvin @timmywil @SimenB @mgol