Skip to content

Remove internal args to .on & .remove #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgol opened this issue May 12, 2015 · 2 comments · Fixed by #2366
Closed

Remove internal args to .on & .remove #2301

mgol opened this issue May 12, 2015 · 2 comments · Fixed by #2366
Assignees
@mgol
Labels
Event Manipulation
Milestone
1.12.0/2.2.0

Comments

@mgol
Copy link
Member

mgol commented May 12, 2015

We shouldn't be exposing our private APIs, even if it's just via undocumented additional params.

I found 2 such occurrences: .on & .remove.
@mgol mgol self-assigned this May 12, 2015
@mgol mgol added this to the 3.0.0 milestone May 12, 2015
@dmethvin
Copy link
Member

I agree. We got rid of several of these earlier, not sure why these stayed around.

mgol added a commit to mgol/jquery that referenced this issue Jun 1, 2015
@mgol
Event: Remove an internal argument to the on method
e19a079 
Refs jquerygh-2301
mgol added a commit to mgol/jquery that referenced this issue Jun 1, 2015
@mgol
Manipulation: Remove an internal argument to the remove method
ea6c1b5 
Fixes jquerygh-2301
@mgol mgol mentioned this issue Jun 1, 2015
Merged
@mgol
Copy link
Member Author

mgol commented Jun 1, 2015

PR: #2366

mgol added a commit to mgol/jquery that referenced this issue Jun 13, 2015
@mgol
Event: Remove an internal argument to the on method
43ffd34 
Refs jquerygh-2301
mgol added a commit to mgol/jquery that referenced this issue Jun 13, 2015
@mgol
Manipulation: Remove an internal argument to the remove method
2aa6942 
Fixes jquerygh-2301
Closes jquerygh-2366
mgol added a commit to mgol/jquery that referenced this issue Jun 13, 2015
@mgol
Event: Remove an internal argument to the on method
04a2969 
Refs jquerygh-2301
mgol added a commit to mgol/jquery that referenced this issue Jun 13, 2015
@mgol
Manipulation: Remove an internal argument to the remove method
349edbd 
Fixes jquerygh-2301
Closes jquerygh-2366
mgol added a commit that referenced this issue Jun 13, 2015
@mgol
Event: Remove an internal argument to the on method
473d2db 
(cherry-picked from 04a2969)

Refs gh-2301
mgol added a commit that referenced this issue Jun 13, 2015
@mgol
Manipulation: Remove an internal argument to the remove method
b819be3 
(cherry-picked from 349edbd)

Fixes gh-2301
Closes gh-2366
mgol added a commit that referenced this issue Nov 10, 2015
@mgol @markelog
Event: Remove an internal argument to the on method
2c70269 
Refs gh-2301
mgol added a commit that referenced this issue Nov 10, 2015
@mgol @markelog
Manipulation: Remove an internal argument to the remove method
959a0ca 
Fixes gh-2301
Closes gh-2366
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
Event Manipulation
Milestone
1.12.0/2.2.0
Development

Successfully merging a pull request may close this issue.

Remove internal args to on & remove methods mgol/jquery
2 participants
@dmethvin @mgol