Skip to content

Events: originalEvent must not be an empty object #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gabrielschulhof opened this issue May 12, 2015 · 4 comments
Closed

Events: originalEvent must not be an empty object #2300

gabrielschulhof opened this issue May 12, 2015 · 4 comments
Assignees
@markelog
Labels
Blocker Event
Milestone
1.12.0/2.2.0

Comments

@gabrielschulhof
Copy link

Since a873558 we must make sure that all objects that are supposed to be events are events. Thus, code like originalEvent: {} must be replaced with originalEvent: new jQuery.Event()
@mgol mgol added this to the 3.0.0 milestone May 12, 2015
@mgol mgol added the Event label May 12, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery that referenced this issue May 12, 2015
Event: originalEvent must not be an empty object
5c703d6 
Fixes jquerygh-2300
@timmywil
Copy link
Member

I took the liberty of assigning you, @markelog. :)

@markelog
Copy link
Member

@timmywil Sure thing,

Since a873558 we must make sure that all objects that are supposed to be events are events.

Why?

@timmywil
Copy link
Member

Because our simulated focus event doesn't have those methods.

@gabrielschulhof
Copy link
Author

@gibson042 mentioned that we may be able to get rid of the fake originalEvent altogether.

gabrielschulhof pushed a commit to gabrielschulhof/jquery that referenced this issue May 12, 2015
Event: originalEvent must not be an empty object
1f42c5e 
Fixes jquerygh-2300
gabrielschulhof pushed a commit to gabrielschulhof/jquery that referenced this issue May 12, 2015
Event: Remove fake originalEvent from jQuery.Event.simulate
8edb3cb 
Fixes jquerygh-2300
@gabrielschulhof gabrielschulhof mentioned this issue May 12, 2015
Closed
gabrielschulhof pushed a commit to gabrielschulhof/jquery that referenced this issue May 13, 2015
Event: Remove fake originalEvent from jQuery.Event.simulate
2b76f38 
Fixes jquerygh-2300
@arschmitz arschmitz mentioned this issue May 14, 2015
Closed
markelog pushed a commit to markelog/jquery that referenced this issue May 20, 2015
@markelog
Event: Remove fake originalEvent from jQuery.Event.simulate
2506c5d 
Fixes jquerygh-2300
markelog added a commit to markelog/jquery that referenced this issue May 20, 2015
@markelog
Event: remove outdated originalEvent hack
841e7fa 
Ref jquerygh-2300
Ref 2506c5d
markelog added a commit to markelog/jquery that referenced this issue May 20, 2015
@markelog
Event: improve originalEvent hack
bb5e311 
Ref jquerygh-2300
Ref 841e7fa
This was referenced May 20, 2015
Closed
Closed
markelog added a commit to markelog/jquery that referenced this issue May 28, 2015
@markelog
Event: improve originalEvent hack
330938b 
Ref jquerygh-2300
Ref 841e7fa
markelog pushed a commit that referenced this issue Nov 10, 2015
@markelog
Event: Remove fake originalEvent from jQuery.Event.simulate
e1b42fb 
Fixes gh-2300
Closes gh-2303
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016
@arschmitz arschmitz mentioned this issue Feb 11, 2016
Closed
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@markelog markelog

Labels
Blocker Event
Milestone
1.12.0/2.2.0
Development

Successfully merging a pull request may close this issue.

Event: Remove fake originalEvent from jQuery.Event.simulate gabrielschulhof/jquery
5 participants
@dmethvin @timmywil @markelog @gabrielschulhof @mgol