-
Notifications
You must be signed in to change notification settings - Fork 20.6k
isArraylike #2238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The code still acts as a defense against form aliasing: http://jsfiddle.net/Lz0k4bn4/ We can either drop support or add a unit test. |
Is this change fixing a bug, or removing a feature? 😈 The |
Nuh-uh: http://jsfiddle.net/Lz0k4bn4/1/ (check the console) |
I must be missing something, here are some extra console logs: http://jsfiddle.net/Lz0k4bn4/2/ |
Never supported this usage, in fact, we have always closed issues like that, see the most recent one |
I agree, we have been closing them not because we are happy with having this bug, but because the aliasing problem is too hard to solve. |
I'm fine with removing it. |
if ( obj.nodeType === 1 && length ) {
return true;
}
this is not useful, because nodeList has no nodeType.
The text was updated successfully, but these errors were encountered: