Skip to content

Update jsdom & drop obsolete workarounds #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgol opened this issue Mar 20, 2015 · 0 comments · Fixed by #2154
Closed

Update jsdom & drop obsolete workarounds #2153

mgol opened this issue Mar 20, 2015 · 0 comments · Fixed by #2154
Assignees
@mgol
Labels
Core
Milestone
1.12.0/2.2.0

Comments

@mgol
Copy link
Member

mgol commented Mar 20, 2015

We currently test on jsdom 1.5.x. The latest version supporting Node.js is 3.1.2, we should test on that. For example, in jsdom 3.1.2 a document created via document.implementation.createHTMLDocument( "" ) has a body.
@mgol mgol mentioned this issue Mar 20, 2015
Merged
mgol added a commit to mgol/jquery that referenced this issue Mar 20, 2015
@mgol
Core: Update tested jsdom, drop obsolete workarounds
b576841 
The latest version supporting Node.js is 3.1.2; some workarounds are not needed
for this version. For example, in jsdom 3.1.2 a document created via
document.implementation.createHTMLDocument( "" ) has a body.

Fixes jquerygh-2153
Closes jquerygh-2154
@mgol mgol self-assigned this Mar 20, 2015
@mgol mgol added the Core label Mar 20, 2015
@mgol mgol added this to the 3.0.0 milestone Mar 20, 2015
mgol added a commit to mgol/jquery that referenced this issue Mar 25, 2015
@mgol
Core: Update tested jsdom, drop obsolete workarounds
97af1cc 
The latest version supporting Node.js is 3.1.2; some workarounds are not needed
for this version. For example, in jsdom 3.1.2 a document created via
document.implementation.createHTMLDocument( "" ) has a body.

Fixes jquerygh-2153
Closes jquerygh-2154
mgol added a commit that referenced this issue Mar 25, 2015
@mgol
Core: Update tested jsdom, drop obsolete workarounds
19c0377 
The latest version supporting Node.js is 3.1.2; some workarounds are not needed
for this version. For example, in jsdom 3.1.2 a document created via
document.implementation.createHTMLDocument( "" ) has a body.

(partially cherry-picked from 95c0a10)

Fixes gh-2153
Closes gh-2154
mgol added a commit to mgol/jquery that referenced this issue Mar 30, 2015
@mgol
Core: Update tested jsdom, drop obsolete workarounds
06f6cd1 
The latest version supporting Node.js is 3.1.2; some workarounds are not needed
for this version. For example, in jsdom 3.1.2 a document created via
document.implementation.createHTMLDocument( "" ) has a body.

Fixes jquerygh-2153
Closes jquerygh-2154
mgol added a commit that referenced this issue Nov 10, 2015
@mgol @markelog
Core: Update tested jsdom, drop obsolete workarounds
5763cd0 
The latest version supporting Node.js is 3.1.2; some workarounds are not needed
for this version. For example, in jsdom 3.1.2 a document created via
document.implementation.createHTMLDocument( "" ) has a body.

Fixes gh-2153
Closes gh-2154
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
Core
Milestone
1.12.0/2.2.0
Development

Successfully merging a pull request may close this issue.

Core: Update tested jsdom, drop obsolete workarounds mgol/jquery
2 participants
@dmethvin @mgol