Skip to content

IE10+ fail the test for modifying offset values in a callback #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgol opened this issue Mar 16, 2015 · 0 comments
Closed

IE10+ fail the test for modifying offset values in a callback #2147

mgol opened this issue Mar 16, 2015 · 0 comments
Assignees
@mgol
Labels
Offset
Milestone
1.12.0/2.2.0

Comments

@mgol
Copy link
Member

mgol commented Mar 16, 2015

See http://swarm.jquery.org/result/63457
@mgol mgol added this to the 3.0.0 milestone Mar 16, 2015
@mgol mgol self-assigned this Mar 16, 2015
@mgol mgol added the Offset label Mar 16, 2015
mgol added a commit to mgol/jquery that referenced this issue Mar 16, 2015
@mgol
Offset: Round offset value for the sake of floating errors
f64c0db 
IE10+ may return not exactly the offset.top value set in an offset callback
if parent has fractional top offset itself. Checking for being close to the
desired result fixes the test error.

Fixes jquerygh-2147
@mgol mgol mentioned this issue Mar 16, 2015
Closed
mgol added a commit to mgol/jquery that referenced this issue Mar 16, 2015
@mgol
Offset: Round offset value for the sake of floating errors
d1e6c3a 
IE10+ may return not exactly the offset.top value set in an offset callback
if parent has fractional top offset itself. Checking for being close to the
desired result fixes the test error.

Fixes jquerygh-2147
@mgol mgol closed this as completed in 62ae2d0 Mar 23, 2015
mgol added a commit that referenced this issue Mar 23, 2015
@mgol
Offset: Round offset value for the sake of floating errors
cd63e9c 
IE10+ may return not exactly the offset.top value set in an offset callback
if parent has fractional top offset itself. Checking for being close to the
desired result fixes the test error.

(cherry-picked from 62ae2d0)

Fixes gh-2147
mgol added a commit that referenced this issue Nov 10, 2015
@mgol @markelog
Offset: Round offset value for the sake of floating errors
4e30176 
IE10+ may return not exactly the offset.top value set in an offset callback
if parent has fractional top offset itself. Checking for being close to the
desired result fixes the test error.

Fixes gh-2147
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
Offset
Milestone
1.12.0/2.2.0
Development

Successfully merging a pull request may close this issue.

Offset: Round offset value for the sake of floating errors mgol/jquery
2 participants
@dmethvin @mgol