Skip to content

Synchronize use of document globals #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gibson042 opened this issue Mar 9, 2015 · 10 comments
Closed

Synchronize use of document globals #2133

gibson042 opened this issue Mar 9, 2015 · 10 comments
Assignees
@mgol
Labels
1.x-only Core CSS wontfix

Comments

@gibson042
Copy link
Member

Changes from 76df9e4 (in particular, definition and use of the document and documentElement variables) never made it to the compat branch, introducing what I feel to be a needless divergence and source of merge conflicts.

@mzgol: agree?
@gibson042 gibson042 added this to the 3.0.0 milestone Mar 9, 2015
@mgol
Copy link
Member

mgol commented Mar 9, 2015

I mostly didn't backport it because this is only required for non-browser environments which we don't support in the compat line. But I have nothing against porting them if that makes cherry-picking easier.

Note, though, that on compat we have a different JSHint config that assumes the browser environment; the one on master only declares window & timer functions.

@timmywil timmywil self-assigned this May 5, 2015
@mgol mgol mentioned this issue Jul 7, 2015
Closed
@mgol mgol mentioned this issue Jul 22, 2015
Closed
@mgol
Copy link
Member

mgol commented Jul 27, 2015

I'll create a document variable as part of #2501 but documentElement doesn't seem worth it - on master it's mostly used in selector-native which is not supported on compat & support tests which use document.body, not document.documentElement on compat.

@mgol
Copy link
Member

mgol commented Jul 27, 2015

support tests which use document.body, not document.documentElement on compat.

BTW, it's worth checking if #1342 (comment) still applies or maybe we could switch from body to documentElement for support tests even on compat.

@mgol mgol assigned mgol and unassigned timmywil Jul 27, 2015
@mgol
Copy link
Member

mgol commented Jul 27, 2015

It seems we can switch from body to documentElement on compat, support tests work fine in IE8 before doc ready. :) PR coming.

EDIT: issue created: #2502.

@mgol mgol mentioned this issue Jul 27, 2015
Closed
@mgol
Copy link
Member

mgol commented Jul 28, 2015

PR: #2504.

mgol added a commit to mgol/jquery that referenced this issue Jul 28, 2015
@mgol
Core: Support non-browser environments
a99ed3c 
Fixes jquerygh-2133
Fixes jquerygh-2501
Closes jquerygh-2504
Refs jquerygh-1950
Refs jquerygh-1949
Refs jquerygh-2397
Refs jquerygh-1537
Refs 842958e
@mgol mgol mentioned this issue Jul 28, 2015
Merged
mgol added a commit to mgol/jquery that referenced this issue Jul 28, 2015
@mgol
Core: Support non-browser environments
29258eb 
Fixes jquerygh-2133
Fixes jquerygh-2501
Closes jquerygh-2504
Refs jquerygh-1950
Refs jquerygh-1949
Refs jquerygh-2397
Refs jquerygh-1537
Refs jquerygh-2504
Refs 842958e
mgol added a commit to mgol/jquery that referenced this issue Aug 16, 2015
@mgol
Core: Support non-browser environments
04ec688 
Fixes jquerygh-2133
Fixes jquerygh-2501
Closes jquerygh-2504
Refs jquerygh-1950
Refs jquerygh-1949
Refs jquerygh-2397
Refs jquerygh-1537
Refs jquerygh-2504
Refs 842958e
@markelog
Copy link
Member

markelog commented Sep 7, 2015

Landed via 04ec688

@markelog markelog closed this as completed Sep 7, 2015
@mgol
Copy link
Member

mgol commented Nov 3, 2015

I'd rather not backport it to 1.12 as there is way more compat code there and it may pose problems for Node.js.

@mgol
Copy link
Member

mgol commented Nov 9, 2015

This is a wontfix now since it was done in connection with #2501.

@mgol mgol removed this from the 3.0.0 milestone Nov 9, 2015
@mgol mgol added the wontfix label Nov 9, 2015
@markelog
Copy link
Member

Since 1.12 will be released, i will remove wontfix label

@markelog markelog removed the wontfix label Dec 22, 2015
@mgol
Copy link
Member

mgol commented Dec 22, 2015

Last time I tried it it caused problems for IE<8. I'd rather it stayed wontfix unless we can verify IE 6-7 don't have problems with it.

@mgol mgol added the wontfix label Jan 27, 2016
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
1.x-only Core CSS wontfix
Milestone
No milestone
Development

No branches or pull requests
4 participants
@timmywil @markelog @gibson042 @mgol