-
Notifications
You must be signed in to change notification settings - Fork 20.6k
Progress doesn't fire after .then() for resolved promises #2013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think this a dup of #2010 but I'll let @gibson042 make the final call. I would say that this may not work in the near future with |
Extremely similar, but not quite a duplicate... @homm, would you like to submit a PR? Both the code and new tests should be straightforward. |
Progress was not shown in some situaations with crop
Suppose we have the Deferred object and try to set handlers on progress for both
.promise()
and.then()
objects:This works as expected, both progress handlers will fire. But if we try to set progress handlers for resolved Deferred, the result will be different:
Only first handler will fire. The problem in tuples order.
Progress
tuple come last, and therefor, when newDefer.notify() is called, newDefer is already resolved and doesn't accept notifying.This bug is similar to #1894, but slightly different.
The text was updated successfully, but these errors were encountered: