Skip to content

pipe doesn't forward progress from already-resolved Deferred #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gibson042 opened this issue Jan 13, 2015 · 0 comments
Closed

pipe doesn't forward progress from already-resolved Deferred #2010

gibson042 opened this issue Jan 13, 2015 · 0 comments
Assignees
@gibson042
Labels
Deferred
Milestone
1.12.0/2.2.0

Comments

@gibson042
Copy link
Member

http://jsfiddle.net/sp6a117y/

Analogous to #1894 in both cause and solution. The new promise never sees progress at all because .done is called on it before .progress:

jQuery.Deferred().resolve().pipe(function() {
    var dfd = jQuery.Deferred().notify( "a" );
    dfd.notify( "b" ).resolve( 1 );
    return dfd;
})
.progress( expectsInvocationWithB );
@gibson042 gibson042 added this to the 3.0.0 milestone Jan 13, 2015
@gibson042 gibson042 mentioned this issue Jan 13, 2015
Closed
4 tasks
@dmethvin dmethvin mentioned this issue Jan 14, 2015
Closed
gibson042 added a commit to gibson042/jquery that referenced this issue Apr 14, 2015
@gibson042
Deferred: Don't swallow progress of a resolved deferred in then
ec91dd7 
Fixes jquerygh-2013
Ref jquerygh-2010
@gibson042 gibson042 mentioned this issue Apr 14, 2015
Closed
gibson042 added a commit to gibson042/jquery that referenced this issue Apr 14, 2015
@gibson042
Deferred: Don't swallow progress of a resolved deferred in then
f6ba8c8 
Fixes jquerygh-2010
@gibson042 gibson042 self-assigned this Apr 14, 2015
gibson042 added a commit to gibson042/jquery that referenced this issue Apr 14, 2015
@gibson042
Deferred: Handle remaining progress/resolve interactions
4d34dcf 
Fixes jquerygh-2010
gibson042 added a commit that referenced this issue Apr 22, 2015
@gibson042
Deferred: Always handle progress callbacks before done/fail
35295f1 
Fixes gh-2013
Fixes gh-2010
Closes gh-2210

(cherry picked from commit 002240a)
gibson042 added a commit that referenced this issue Nov 10, 2015
@gibson042 @markelog
Deferred: Always handle progress callbacks before done/fail
09cf676 
Fixes gh-2013
Fixes gh-2010
Closes gh-2210
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gibson042 gibson042

Labels
Deferred
Milestone
1.12.0/2.2.0
Development

Successfully merging a pull request may close this issue.

Deferred: Don't swallow progress of a resolved deferred in then gibson042/jquery
2 participants
@dmethvin @gibson042