Skip to content

Improve tag name related regexes #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markelog opened this issue Jan 13, 2015 · 7 comments
Closed

Improve tag name related regexes #2005

markelog opened this issue Jan 13, 2015 · 7 comments

Comments

@markelog
Copy link
Member

See discussion in related pull, specifically @gibson042 comment.

@markelog
Copy link
Member Author

@LeonardoBraga interested in providing fix for it?

@LeonardoBraga
Copy link
Contributor

@Marklog - Yes, definitely. Will work on the PR ASAP.

@mgol
Copy link
Member

mgol commented Sep 15, 2015

@LeonardoBraga Still interested?

@LeonardoBraga
Copy link
Contributor

@mzgol Sure. I'll work on it over the weekend and send the PR. Thanks.

@mgol mgol modified the milestones: 3.0.1, 3.0.0 Sep 16, 2015
@dmethvin
Copy link
Member

dmethvin commented Oct 1, 2015

@LeonardoBraga just pinging to see if you're going to send a PR. We'd love to have your contribution!

LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 7, 2015
LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 7, 2015
LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 7, 2015
LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 7, 2015
@LeonardoBraga
Copy link
Contributor

@dmethvin I'm sorry for the delay on sending the PR. Should I also apply the same changes to any other branches and send additional PRs?

@gibson042
Copy link
Member

No need; this is easy to cherry pick.

LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 13, 2015
LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 13, 2015
LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 13, 2015
LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 13, 2015
LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 13, 2015
LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 14, 2015
LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 14, 2015
LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 20, 2015
LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Dec 5, 2015
LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Dec 5, 2015
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

6 participants