-
Notifications
You must be signed in to change notification settings - Fork 20.6k
Code coverage #1965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
and /cc @gnarf |
We already have multiple projects doing this. |
We use coveralls it was really really noisy at first so we disabled the pr comments ( looks like qunit has as well ) which means we lose a lot of the value. I was just looking at they have notification settings with coverage ranges for them now so this may not be as much of an issue any more. Previously every new commit on a PR triggered a coverage comment, which was a lot of noise when there was often absolutely no actual change in coverage. |
In mobile? Istanbul? In what envs do you run it? And How :-) |
@markelog Yes on mobile. We use grunt-coveralls https://www.npmjs.com/package/grunt-coveralls both locally and via travis. |
Yeah, Just check it out - you use istanbul on phantom. |
getting coverage on jQuery Core would be so.... tricky so many "forks" that require a specific actual browser to hit... |
But those problems are apparently solved; istanbul-middleware enables a mode of operation that aggregates results: https://github.com/gotwarlost/istanbul-middleware#client-side-coverage . So it should be as simple as spinning up a node.js server with istanbul-middleware and making sure that the test swarm gets |
+1 |
We would love to see jQuery use Codecov as its coverage provider. I would love to share about the many reasons why I believe Codecov are great fit and industry leading in code coverage. Anything I can do to help this transition I would make myself very available. Thank you! |
Help implement it in a PR and I'm sure we can work together on it! A couple of questions:
I'm sure others will have some more questions :) |
Any CI method works. We have two primary uploading methods for javascript: the native method and the global method. I'll look into creating a pull request, I'll mention you when I create it. Thank you @gnarf
Jenkins: yes. Qunit: yes. Testswarm: should (I have not used this before). We do merge coverage reports automatically and keep record of each one. See here for example (Click on the Unified dropdown).
I can reference our customer repos, but I have not yet ran coverage against jQuery yet. I will try to attempt this during my pull request.
I'm very happy to help out! |
Feel free to ping me (gnarf) in freenode IRC #jquery-dev with any questions/help you'd need from me here. |
Closing in favor of tracking in the Roadmap. |
Evaluate and prototype implementation of code coverage tool. Maybe not even on Core at first, Sizzle?
/cc @timmywil, @mzgol, @gibson042, @jaubourg, @dmethvin
The text was updated successfully, but these errors were encountered: