Skip to content

Don't assume the browser environment in src/, run a smoke-test on Node #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgol opened this issue Dec 18, 2014 · 1 comment
Closed

Don't assume the browser environment in src/, run a smoke-test on Node #1950

mgol opened this issue Dec 18, 2014 · 1 comment
Assignees
@mgol
Labels
Build
Milestone
1.12.0/2.2.0

Comments

@mgol
Copy link
Member

mgol commented Dec 18, 2014

Since we want to support Node.js on the master branch, we cannot rely on globals except window (that is passed to the factory) and setTimeout/clearTimeout/setInterval/clearInterval.

jsHint config should be updated and we should have basic Node smoke-testing so that issues like #1788 don't happen in the future.
mgol added a commit to mgol/jquery that referenced this issue Dec 18, 2014
@mgol
Build: Don't assume the browser environment; smoke test on Node w/ jsdom
f0b5ad7 
Fixes jquerygh-1950
@mgol mgol mentioned this issue Dec 18, 2014
Closed
@mgol mgol added the Build label Dec 18, 2014
@mgol mgol added this to the 3.0.0 milestone Dec 18, 2014
@mgol mgol self-assigned this Dec 18, 2014
mgol added a commit to mgol/jquery that referenced this issue Dec 18, 2014
@mgol
Build: Don't assume the browser environment; smoke test on Node w/ jsdom
30b61b5 
Fixes jquerygh-1950
mgol added a commit to mgol/jquery that referenced this issue Dec 18, 2014
@mgol
Build: Don't assume the browser environment; smoke test on Node w/ jsdom
3143efc 
Fixes jquerygh-1950
mgol added a commit to mgol/jquery that referenced this issue Dec 26, 2014
@mgol
Build: Don't assume the browser environment; smoke test on Node w/ jsdom
5a3f914 
Fixes jquerygh-1950
@mgol mgol closed this as completed in 76df9e4 Dec 26, 2014
@mgol mgol mentioned this issue Jul 28, 2015
Merged
mgol added a commit to mgol/jquery that referenced this issue Jul 28, 2015
@mgol
Core: Support non-browser environments
d79dbf0 
Fixes jquerygh-2501
Closes jquerygh-2504
Refs jquerygh-1950
Refs jquerygh-1949
Refs jquerygh-2397
Refs jquerygh-1537
Refs 842958e
mgol added a commit to mgol/jquery that referenced this issue Jul 28, 2015
@mgol
Core: Support non-browser environments
a99ed3c 
Fixes jquerygh-2133
Fixes jquerygh-2501
Closes jquerygh-2504
Refs jquerygh-1950
Refs jquerygh-1949
Refs jquerygh-2397
Refs jquerygh-1537
Refs 842958e
mgol added a commit to mgol/jquery that referenced this issue Jul 28, 2015
@mgol
Core: Support non-browser environments
29258eb 
Fixes jquerygh-2133
Fixes jquerygh-2501
Closes jquerygh-2504
Refs jquerygh-1950
Refs jquerygh-1949
Refs jquerygh-2397
Refs jquerygh-1537
Refs jquerygh-2504
Refs 842958e
mgol added a commit to mgol/jquery that referenced this issue Aug 16, 2015
@mgol
Core: Support non-browser environments
04ec688 
Fixes jquerygh-2133
Fixes jquerygh-2501
Closes jquerygh-2504
Refs jquerygh-1950
Refs jquerygh-1949
Refs jquerygh-2397
Refs jquerygh-1537
Refs jquerygh-2504
Refs 842958e
mgol added a commit that referenced this issue Nov 10, 2015
@mgol @markelog
Build: Don't assume the browser environment; smoke test on Node w/ jsdom
115b2bb 
Fixes gh-1950
Closes gh-1949
@mgol
Copy link
Member Author

mgol commented Mar 6, 2016

This has been backported to 1.12.0 & 2.2.0 so I changed the milestone (it used to say 3.0.0).

@mgol mgol modified the milestones: 1.12.0/2.2.0, 3.0.0 Mar 6, 2016
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
Build
Milestone
1.12.0/2.2.0
Development

Successfully merging a pull request may close this issue.

Build: Don't assume the browser environment; smoke test on Node w/ jsdom mgol/jquery
1 participant
@mgol