Skip to content

ScrollLeft and ScrollTop reinitializing themselves in an iframe contentDocument #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hilnius opened this issue Dec 17, 2014 · 6 comments
Closed

ScrollLeft and ScrollTop reinitializing themselves in an iframe contentDocument #1945

hilnius opened this issue Dec 17, 2014 · 6 comments
Labels
Bug Offset
Milestone
1.12.0/2.2.0

Comments

@hilnius
Copy link

hilnius commented Dec 17, 2014

When scrolling manually in an iframe using $($('#iframe').contentWindow).scrollTop(y).scrollLeft(x), the scrollLeft reinitializes the scrollTop
For a demo, see this plunker:
http://plnkr.co/edit/tbn2UJ72frQG16vA9Z5y?p=preview
@dmethvin
Copy link
Member

Oh that's a good one. It's funny, we go to extra lengths to get the correct window and then we don't use it when setting the values. So what's happening is that the iframe gets the parent window's value.

@dmethvin dmethvin added this to the 3.0.0 milestone Dec 17, 2014
@timmywil
Copy link
Member

Yea, we're good like that.

@timmywil
Copy link
Member

Easy fix, but it seems we need an iframe test.

@dmethvin
Copy link
Member

Oh and you're probably better using the iframe window's .scrollTo() when setting both.

@araghava
Copy link
Contributor

Is anyone working on this? If so can I take it? @hilnius

@mgol
Copy link
Member

mgol commented Dec 20, 2014

@araghava If you want, go for it!

araghava added a commit to araghava/jquery that referenced this issue Dec 21, 2014
@araghava
Event: fixing incorrect window bug with scrollTop/Left in iframes
4f35f25 
Fixes jquerygh-1945
@araghava araghava mentioned this issue Dec 21, 2014
Closed
araghava added a commit to araghava/jquery that referenced this issue Dec 21, 2014
@araghava
Event: fixing incorrect window bug with scrollTop/Left in iframes
3fd7134 
Fixes jquerygh-1945
araghava added a commit to araghava/jquery that referenced this issue Dec 23, 2014
@araghava
Event: fixing incorrect window bug with scrollTop/Left in iframes
25c7c6f 
Fixes jquerygh-1945
markelog pushed a commit that referenced this issue Nov 10, 2015
@araghava @markelog
Event: fix incorrect window bug with scrollTop/Left in iframes
bce6101 
Fixes gh-1945
Closes gh-1959
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Offset
Milestone
1.12.0/2.2.0
Development

No branches or pull requests
5 participants
@dmethvin @timmywil @mgol @araghava @hilnius