Skip to content

Release: zip files are empty #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmethvin opened this issue Dec 17, 2014 · 4 comments
Closed

Release: zip files are empty #1940

dmethvin opened this issue Dec 17, 2014 · 4 comments
Assignees
@timmywil
Labels
Build
Milestone
1.12.0/2.2.0

Comments

@dmethvin
Copy link
Member

The release script is supposed to build two zip files that we distribute to the CDNs. They are created but always zero-length.

googlecdn-jquery-VERSION.zip should have the release files (.js, .min.js, and .min.map) named without version numbers and internally consistent (e.g., the map should reference the file without version number). This file is also distributed to cdnjs.

mscdn-jquery-VERSION.zip should have the release files with version numbers.
@dmethvin dmethvin added this to the 3.0.0 milestone Dec 17, 2014
@dmethvin
Copy link
Member Author

Better to have the test runs create these zip files than skip it:

https://github.com/jquery/jquery/blob/1.11-stable/build/release.js#L81-84

@scottgonzalez
Copy link
Member

Looking at that code, they are created for test runs. They're not created for pre-releases.

@dmethvin
Copy link
Member Author

Oh right, I was confusing the meaning of the variable.

@dmethvin
Copy link
Member Author

This is the final step in the build, maybe the archive creation in happening async and we're not waiting on it before exiting.

@timmywil timmywil added the Build label Jan 12, 2015
@timmywil timmywil modified the milestone: 3.0.0 Jan 29, 2015
timmywil added a commit that referenced this issue Jan 30, 2015
@timmywil
Release: fix CDN archive creation
7352216 
Fixes gh-1940
timmywil added a commit that referenced this issue Nov 10, 2015
@timmywil @markelog
Release: fix CDN archive creation
546259d 
Fixes gh-1940
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timmywil timmywil

Labels
Build
Milestone
1.12.0/2.2.0
Development

No branches or pull requests
3 participants
@scottgonzalez @dmethvin @timmywil