-
Notifications
You must be signed in to change notification settings - Fork 20.6k
"define" is not defined error. Broken build #1768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Comment author: corbacho
Ignore the jsfiddle link. These are correct: |
Comment author: corbacho I reduced the bug to this command (building an empty jQuery) grunt build:*
it contains these 2 lines: define([]); define("jquery", function(){}); |
Comment author: dmethvin Thanks for reducing it more. I'll mark this open, patches or further testing welcome. |
Comment author: corbacho Pull request that fix one of the issues: define([]);
#1569 |
Originally reported by corbacho at: http://bugs.jquery.com/ticket/15061
When building a custom jQuery (master branch) with this command:
It will output about the line 47:
This produces the error
Why I'm using grunt build? I know that "grunt custom" is the recommended alias, but I'm trying to build a minimum possible jQuery that contains the necessary code for a reliable $(document).ready() . I want to propose this solution to be part of the upcoming Drupal 8 core, as an alternative to domready solution https://github.com/ded/domready that we are using now
The whole command is :
This builds a 11Kb size domready solution. 5Kb gzipped
Removing the buggy line mentioned before, it works: http://jsfiddle.net/WnhWc/2/
Issue reported for jQuery 2.1.0
The text was updated successfully, but these errors were encountered: