Skip to content

Edge self-replacement cases of replaceWith #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgol opened this issue Oct 21, 2014 · 0 comments
Closed

Edge self-replacement cases of replaceWith #1752

mgol opened this issue Oct 21, 2014 · 0 comments
Labels
Manipulation

Comments

@mgol
Copy link
Member

mgol commented Oct 21, 2014

Originally reported by markelog at: http://bugs.jquery.com/ticket/14380

I created this ticket as per gibson042 request in  https://github.com/jquery/jquery/pull/1276#issuecomment-24526014.

See  http://jsfiddle.net/gejGm/ for essence of it.

Related to #4087. I bring this issue up in IRC channel, right after fix for #4087 was landed, back then, it was decided that this cases are the rare ones and they do not worth it.

Given that i'm not aware of any of these kind of problems submitted to the bug tracker and that #4087 has lived for 5 years without a lot of attention to it and taking into account complexity of the solution for this ticket, which probably would negatively reflect on size and speed, i'm inclined to close this issue with "patchwelcome" resolution.

Issue reported for jQuery 1.10.2
gibson042 added a commit to gibson042/jquery that referenced this issue Apr 13, 2015
@gibson042
Manipulation: Detect sneaky no-content replaceWith input
e0fe8d9 
Fixes jquerygh-2204
Ref 642e9a4
Closes jquerygh-1752
markelog added a commit to markelog/jquery that referenced this issue Apr 20, 2015
@markelog
Manipulation: Detect sneaky no-content replaceWith input
03329c4 
Ref 642e9a4
Fixes jquerygh-2204
Closes jquerygh-1752
gibson042 added a commit that referenced this issue Apr 30, 2015
@gibson042
Manipulation: Detect sneaky no-content replaceWith input
4cafb58 
Fixes gh-2204
Ref 642e9a4
Closes gh-1752
Closes gh-2206

(cherry picked from commit 4b27ae1)

Conflicts:
	src/manipulation.js
	test/unit/manipulation.js
gibson042 added a commit that referenced this issue Nov 10, 2015
@gibson042 @markelog
Manipulation: Detect sneaky no-content replaceWith input
618bca1 
Fixes gh-2204
Ref 642e9a4
Closes gh-1752
Closes gh-2206
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Manipulation
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gibson042 @mgol